fixed the usage of CUSTOM_TLS_CERT from subscriber-configmap to subsc… #4291
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @imrajdas @Saranya-jena @neelanjan00 @namkyu1999 Can you please review this PR? |
imrajdas
reviewed
Nov 13, 2023
| "INFRA_ID": infraData["INFRA_ID"], | ||
| "ACCESS_KEY": infraData["ACCESS_KEY"], | ||
| "INFRA_ID": infraData["INFRA_ID"], | ||
| "CUSTOM_TLS_SECRET": infraData["CUSTOM_TLS_SECRET"], |
There was a problem hiding this comment.
@Saranya-jena - where are we setting the value CUSTOM_TLS_SECRET? In system env or from the ui
There was a problem hiding this comment.
As far as I know we are setting the the CUSTOM_TLS_SECRET from the system env
vanshBhatia-A4k9
approved these changes
Dec 8, 2023
|
@Saranya-jena @namkyu1999 Can you review this PR? |
amityt
approved these changes
Dec 15, 2023
Jonsy13
approved these changes
Jan 5, 2024
namkyu1999
approved these changes
Jan 5, 2024
|
@srikanth-iyengar can you please resolve the conflicts? Will merge post that! |
Yup will resolve conflicts |
srikanth-iyengar
force-pushed
the
issue/3943
branch
from
9f93e79
to
3f31f7f
Compare
Signed-off-by: Srikanth Iyengar <[email protected]>
srikanth-iyengar
force-pushed
the
issue/3943
branch
from
3f31f7f
to
b0cdfbd
Compare
|
@Saranya-jena Solved conflicts |
|
Can you resolve conflicts again? will merge it afterwards |
|
Yeah sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #3943 Changed the required k8s manifest and the corresponding usage of the changes in the subscriber pkg.
Types of changes
Checklist
Dependency
Special notes for your reviewer: