Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate chaos-workflow and chaos-workflow-run in graphql-server #4015

Closed
SohamRatnaparkhi opened this issue Jun 20, 2023 · 1 comment
Closed

Separate chaos-workflow and chaos-workflow-run in graphql-server #4015

SohamRatnaparkhi opened this issue Jun 20, 2023 · 1 comment
Assignees
@SohamRatnaparkhi

Comments

@SohamRatnaparkhi
Copy link
Contributor

The handler.go (link) in graphql-server/pkg/chaos-workflow/handler/ (link) has a lot of code and hence can be hard to manage. But that code can be broadly divided into 3 types:

  1. The functions specifically related to chaos-workflows are:-

    • CreateChaosWorkflow
    • DeleteChaosWorkflow
    • TerminateChaosWorkflow
    • UpdateChaosWorkflow
    • ListWorkflows
    • CreateWorkflowTemplate
    • ListWorkflowManifests
    • GetWorkflowManifestByID
    • DeleteWorkflowTemplate
    • isTemplateAvailable

  2. The functions specifically related to running a chaos-workflow are:-

    • ListWorkflowRuns
    • ChaosWorkflowRun
    • ReRunChaosWorkFlow
    • SyncWorkflowRun

  3. Others

    • PodLog
    • GetLogs
    • KubeObj

So, based on the above analysis, we can create 2 separate packages - chaos-workflow(which already exists) and chaos-workflow-run.
@SohamRatnaparkhi
Copy link
Contributor Author

A visual representation of the above distinction
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SohamRatnaparkhi SohamRatnaparkhi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SohamRatnaparkhi