Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(litmus): adding "ns.svc.cluster.local" to urls #371

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jlplasce
Copy link

@jlplasce jlplasce commented Apr 7, 2024

Adding full service fqdn to the end of service urls to assist with proxied environments

What this PR does / why we need it:

In proxied environments, you can get Litmus to operate properly by setting proxies in the environment args. However, the service names are hardcoded just to the service name itself without any FQDN (i.e. "http://litmus-server-service:9002/") which will inadvertently send the traffic through the Proxy.
Typically, in these proxied environments you'd put "cluster.local" in the no_proxy setting so internal cluster traffic is not proxied - since the service names are not a full domain path, we run in to issues. This PR appends the standard ".svc.cluster.local" to the nginx pass URLs as well as the DB_SERVER urls so that connection to those services are caught by the no_proxy settings

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped

Adding full service fqdn to the end of service urls to assist with proxied environments

Signed-off-by: Jose Plascencia <[email protected]>
@uditgaurav
Copy link
Member

Hi @jlplasce, thank you for submitting the pull request! It appears there are some conflicts that likely stem from version bumps. Could you please take a moment to resolve these? If you need any assistance, feel free to reach out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants