Remove duplicate labels in litmus-agent charts: #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove selector in deployment of sub-charts since they were already include in the labels - Update label of litmus-agent to remove duplicate - Upgrade version of subchart to 0.2.1 and charts to 0.2.2 - Regenerate docs with helm-docs Signed-off-by: Calvin Audier <[email protected]>
Calvinaud
requested review from
ksatchit,
Jasstkn,
ajeshbaby,
gdsoumya,
imrajdas and
ispeakc0de
as code owners
|
Hi @Calvinaud , Thanks for the PR. Can you please update the branch with master once. |
Signed-off-by: Calvin Audier <[email protected]>
|
Hi @uditgaurav updated the PR and resolved conflict bumped version of chart sub/chart to 3.6.1. |
Jasstkn
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove duplicate labels in litmus-agent chart. The issue was introduced by me in #327.
Which issue this PR fixes
*(optional, in `fixes #361
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]