Merge pull request #103 from lista-dao/feature/lunchPoolOperator

fea: ClisBNBLaunchPoolDistributor add operator role

Author: qingyang-lista

contracts/dao/ClisBNBLaunchPoolDistributor.sol

@@ -57,6 +57,9 @@ contract ClisBNBLaunchPoolDistributor is Initializable, AccessControlUpgradeable
     // token => unclaimedAmount
     mapping(address => uint256) public totalUnclaimedAmount;
 
+    // OPERATOR role
+    bytes32 public constant OPERATOR = keccak256("OPERATOR");
+
     /// @custom:oz-upgrades-unsafe-allow constructor
     constructor() {
         _disableInitializers();
@@ -111,7 +114,7 @@ contract ClisBNBLaunchPoolDistributor is Initializable, AccessControlUpgradeable
      * @param _totalAmount Total amount of the reward epoch
      */
     function setEpochMerkleRoot(uint64 _epochId, bytes32 _merkleRoot, address _token, uint256 _startTime, uint256 _endTime, uint256 _totalAmount)
-        external onlyRole(DEFAULT_ADMIN_ROLE)
+        external onlyRole(OPERATOR)
     {
         require(_epochId == nextEpochId, "Invalid epochId");
         require(_merkleRoot != bytes32(0), "Invalid merkle root");
@@ -136,7 +139,7 @@ contract ClisBNBLaunchPoolDistributor is Initializable, AccessControlUpgradeable
      * @dev Revoke the reward of the given epoch;
      * @param _epochId Id of epoch
      */
-    function revokeEpoch(uint64 _epochId) external onlyRole(DEFAULT_ADMIN_ROLE) {
+    function revokeEpoch(uint64 _epochId) external onlyRole(OPERATOR) {
         Epoch storage epoch = epochs[_epochId];
         require(epoch.startTime > block.timestamp, "Epoch already started");
         require(epoch.totalAmount > 0, "Invalid epochId");

test/dao/ClisBNBLaunchPoolDistributor.t.sol

@@ -17,6 +17,7 @@ contract ClisBNBLaunchPoolDistributorTest is Test {
     address defaultReceiver = 0x78Ab74C7EC3592B5298CB912f31bD8Fb80A57DC0;
     address proxyAdminOwner = 0x8d388136d578dCD791D081c6042284CED6d9B0c6;
     address oneInchRouter = 0x111111125421cA6dc452d289314280a0f8842A65;
+    address operator;
 
     ClisBNBLaunchPoolDistributor cliBNBLaunchPoolDistributor;
 
@@ -33,6 +34,7 @@ contract ClisBNBLaunchPoolDistributorTest is Test {
     bytes32[] public l2;
 
     function setUp() public {
+        operator = makeAddr("operator");
         mainnet = vm.createSelectFork("https://bsc-dataseed.binance.org");
 
         chainid = block.chainid;
@@ -70,6 +72,10 @@ contract ClisBNBLaunchPoolDistributorTest is Test {
         );
 
         cliBNBLaunchPoolDistributor = ClisBNBLaunchPoolDistributor(payable(address(clisBNBLPDistributorProxy)));
+
+        vm.startPrank(admin);
+        cliBNBLaunchPoolDistributor.grantRole(cliBNBLaunchPoolDistributor.OPERATOR(), operator);
+        vm.stopPrank();
     }
 
     function test_setUp() public {
@@ -91,7 +97,7 @@ contract ClisBNBLaunchPoolDistributorTest is Test {
         ClisBNBLaunchPoolDistributor.Epoch[] memory before = cliBNBLaunchPoolDistributor.getEpochs(epochIds);
         assertEq(0, before[0].startTime);
 
-        vm.startPrank(admin);
+        vm.startPrank(operator);
         cliBNBLaunchPoolDistributor.setEpochMerkleRoot(0, root, address(lista), block.timestamp + 10, block.timestamp + 1000, 1737e18);
         vm.stopPrank();
 
@@ -109,7 +115,7 @@ contract ClisBNBLaunchPoolDistributorTest is Test {
         ClisBNBLaunchPoolDistributor.Epoch[] memory before = cliBNBLaunchPoolDistributor.getEpochs(epochIds);
         assertEq(0, before[0].startTime);
 
-        vm.startPrank(admin);
+        vm.startPrank(operator);
         cliBNBLaunchPoolDistributor.setEpochMerkleRoot(0, root, address(0), block.timestamp + 10, block.timestamp + 1000, 1737e18);
         vm.stopPrank();
 
@@ -122,23 +128,58 @@ contract ClisBNBLaunchPoolDistributorTest is Test {
     }
 
     function test_setEpochMerkleRoot_invalid_epochId() public {
-        vm.startPrank(admin);
+        vm.startPrank(operator);
         vm.expectRevert("Invalid epochId");
         cliBNBLaunchPoolDistributor.setEpochMerkleRoot(1, root, address(lista), block.timestamp + 10, block.timestamp + 1000, 1737e18);
         vm.stopPrank();
     }
 
     function test_setEpochMerkleRoot_acl() public {
         vm.startPrank(bot);
-        vm.expectRevert("AccessControl: account 0x00000000000000000000000000000000003a11aa is missing role 0x0000000000000000000000000000000000000000000000000000000000000000");
+        vm.expectRevert("AccessControl: account 0x00000000000000000000000000000000003a11aa is missing role 0x523a704056dcd17bcf83bed8b68c59416dac1119be77755efe3bde0a64e46e0c");
         cliBNBLaunchPoolDistributor.setEpochMerkleRoot(0, root, address(lista), block.timestamp + 10, block.timestamp + 1000, 1737e18);
         vm.stopPrank();
     }
 
     function test_revokeEpoch_ok() public {
         test_setEpochMerkleRoot_ok();
 
-        vm.startPrank(admin);
+        vm.startPrank(operator);
+        cliBNBLaunchPoolDistributor.revokeEpoch(0);
+        vm.stopPrank();
+
+        uint64[] memory epochIds = new uint64[](1);
+        epochIds[0] = 0;
+        ClisBNBLaunchPoolDistributor.Epoch[] memory actual = cliBNBLaunchPoolDistributor.getEpochs(epochIds);
+
+        assertEq(bytes32(0), actual[0].merkleRoot);
+        assertEq(0, actual[0].startTime);
+        assertEq(0, actual[0].endTime);
+        assertEq(0, actual[0].totalAmount);
+    }
+
+    function test_operatorSetEpochMerkleRoot_ok() public {
+        uint64[] memory epochIds = new uint64[](1);
+        epochIds[0] = 0;
+        ClisBNBLaunchPoolDistributor.Epoch[] memory before = cliBNBLaunchPoolDistributor.getEpochs(epochIds);
+        assertEq(0, before[0].startTime);
+
+        vm.startPrank(operator);
+        cliBNBLaunchPoolDistributor.setEpochMerkleRoot(0, root, address(lista), block.timestamp + 10, block.timestamp + 1000, 1737e18);
+        vm.stopPrank();
+
+        ClisBNBLaunchPoolDistributor.Epoch[] memory actual = cliBNBLaunchPoolDistributor.getEpochs(epochIds);
+        assertEq(root, actual[0].merkleRoot);
+        assertEq(address(lista), actual[0].token);
+        assertEq(block.timestamp + 10, actual[0].startTime);
+        assertEq(block.timestamp + 1000, actual[0].endTime);
+        assertEq(1737e18, actual[0].totalAmount);
+    }
+
+    function test_operatorRevokeEpoch_ok() public {
+        test_setEpochMerkleRoot_ok();
+
+        vm.startPrank(operator);
         cliBNBLaunchPoolDistributor.revokeEpoch(0);
         vm.stopPrank();