Merge pull request #1 from gareth-instil/master

lisposter · lisposter · commit 2280ba4a90dd · 2014-06-21T08:28:16.000+08:00
set btn outside of if block
diff --git a/src/angular-zeroclipboard.js b/src/angular-zeroclipboard.js
@@ -47,9 +47,10 @@ directive('uiZeroclip', ['$document', '$window', 'uiZeroclipConfig',
             link: function(scope, elm, attrs) {
                 // config
                 ZeroClipboard.config(zeroclipConfig);
+                var btn = elm[0];
                 if (!attrs.id) {
                     attrs.$set('id', 'uiZeroclip' + _id);
-                    var btn = document.createElement('button');
+                    btn = document.createElement('button');
                     btn.appendChild(document.createTextNode(options.buttonText));
                     btn.setAttribute('data-clipboard-target', 'uiZeroclip' + _id);
                     btn.setAttribute('class', options.buttonClass);
@@ -72,4 +73,4 @@ directive('uiZeroclip', ['$document', '$window', 'uiZeroclipConfig',
             }
         }
     }
-]);
+]);

Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,10 @@ directive('uiZeroclip', ['$document', '$window', 'uiZeroclipConfig',`
`47`	`47`	`link: function(scope, elm, attrs) {`
`48`	`48`	`// config`
`49`	`49`	`ZeroClipboard.config(zeroclipConfig);`
	`50`	`+ var btn = elm[0];`
`50`	`51`	`if (!attrs.id) {`
`51`	`52`	`attrs.$set('id', 'uiZeroclip' + _id);`
`52`		`- var btn = document.createElement('button');`
	`53`	`+ btn = document.createElement('button');`
`53`	`54`	`btn.appendChild(document.createTextNode(options.buttonText));`
`54`	`55`	`btn.setAttribute('data-clipboard-target', 'uiZeroclip' + _id);`
`55`	`56`	`btn.setAttribute('class', options.buttonClass);`
`@@ -72,4 +73,4 @@ directive('uiZeroclip', ['$document', '$window', 'uiZeroclipConfig',`
`72`	`73`	`}`
`73`	`74`	`}`
`74`	`75`	`}`
`75`		`-]);`
	`76`	`+]);`