fix(memory): 修复旧 DB 启动时 repository 列缺失导致崩溃循环

PR #249 在 CREATE TABLE 中加了 repository 列，但 IF NOT EXISTS 对存量
DB 会跳过；紧接其后的 CREATE INDEX ON memories(repository) 在不存在
的列上建索引,直接抛 SqliteError,启动失败,服务 PM2 崩溃循环。

删除冲突的索引创建语句,归属 migrationV3 单一来源(ALTER TABLE 后建索引)。
附带回归测试:构造 pre-v3 schema DB,验证 create 不再抛错且会补列。

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: lishuceo

src/memory/__tests__/database.test.ts

@@ -407,6 +407,50 @@ describe('MemoryDatabase', () => {
       db2.close();
     });
 
+    it('should open a legacy DB that pre-dates the repository column without crashing', async () => {
+      // Regression for PR #249: CREATE INDEX on memories(repository) ran *before*
+      // migration v3 added the column, crashing startup against any pre-existing DB.
+      db.close();
+
+      // Build a legacy schema by hand — pre-v3, no `repository` column.
+      const Database = (await import('better-sqlite3')).default;
+      const legacyPath = join(tempDir, 'legacy.db');
+      const raw = new Database(legacyPath);
+      raw.exec(`
+        CREATE TABLE memories (
+          id TEXT PRIMARY KEY,
+          agent_id TEXT NOT NULL,
+          user_id TEXT,
+          chat_id TEXT,
+          workspace_dir TEXT,
+          type TEXT NOT NULL,
+          content TEXT NOT NULL,
+          tags TEXT DEFAULT '[]',
+          metadata TEXT DEFAULT '{}',
+          confidence REAL NOT NULL DEFAULT 1.0,
+          confidence_level TEXT NOT NULL DEFAULT 'L0',
+          evidence_count INTEGER NOT NULL DEFAULT 1,
+          valid_at TEXT NOT NULL,
+          invalid_at TEXT,
+          superseded_by TEXT,
+          ttl TEXT,
+          source_chat_id TEXT,
+          source_message_id TEXT,
+          created_at TEXT NOT NULL,
+          updated_at TEXT NOT NULL,
+          last_accessed_at TEXT
+        );
+      `);
+      raw.pragma('user_version = 0');
+      raw.close();
+
+      // Should NOT throw "SQLITE_ERROR: no such column: repository".
+      const migrated = await MemoryDatabase.create(legacyPath);
+      const cols = migrated.db.prepare(`PRAGMA table_info(memories)`).all() as Array<{ name: string }>;
+      expect(cols.some(c => c.name === 'repository')).toBe(true);
+      migrated.close();
+    });
+
     it('should not re-run migrations on subsequent opens', async () => {
       db.close();
 

src/memory/database.ts

@@ -248,7 +248,6 @@ export class MemoryDatabase {
       CREATE INDEX IF NOT EXISTS idx_memories_type ON memories(type);
       CREATE INDEX IF NOT EXISTS idx_memories_valid ON memories(invalid_at);
       CREATE INDEX IF NOT EXISTS idx_memories_workspace ON memories(workspace_dir);
-      CREATE INDEX IF NOT EXISTS idx_memories_repository ON memories(repository);
     `);
 
     // vec0 virtual table (conditional, with cosine distance)