-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] MediaInfo Plugin for Emby - Incorrect version of MKVPROPEDIT #936
Comments
I'll work on this request. |
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
I've finished updating the code, I just need to finish testing it. |
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is locked due to inactivity |
Is this a new feature request?
Name of mod
MediaInfo Plugin for Emby (emby-mediainfo-plugin)
Wanted change
Either implement my original version of the mod (I never raised a ticket to PR yet as I was waiting for feedback from plugin community on if it was working) which supersedes this one by 5 months
Or install the correct version of MKVPROPEDIT as outlined in the MediaInfo plugin wiki should be capped to version 70.
Reason for change
As outlined in the MediaInfo plugin wiki (https://github.com/Cheesegeezer/MediaInfoWiki/wiki) versions above version 70 are to be used at the owners own risk.
You must agree to this for the plugin to operate if it detects a newer version.
As this plugin makes changes to metadata on media files. This is a concern if the user is unaware of what the ramifications of this are.
Proposed code change
Either refer to Docker-MediaInfo-PreReq for a script that does handle this or refer to my implementation, which I have now updated to have a template fork and also handle the the recent changes to the base image using noble which broke the installation of v70 - emby-mediainfo-plugin-prereq
The text was updated successfully, but these errors were encountered: