fix: need update exclusion zone when screen was added or removed #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request fixes an issue where the exclusion zone was not being updated when a screen was added or removed. It also corrects the calculation of the bottom strut partial. The changes involve connecting the Sequence diagram for screen added eventsequenceDiagram
participant QGuiApplication
participant LayerShellEmulation
participant QTimer
QGuiApplication->>LayerShellEmulation: screenAdded(newScreen)
activate LayerShellEmulation
LayerShellEmulation->>newScreen: connect(geometryChanged, onPositionChanged)
LayerShellEmulation->>newScreen: connect(geometryChanged, QTimer::start)
LayerShellEmulation->>QTimer: start()
deactivate LayerShellEmulation
Sequence diagram for screen removed eventsequenceDiagram
participant QGuiApplication
participant LayerShellEmulation
participant QTimer
QGuiApplication->>LayerShellEmulation: screenRemoved()
activate LayerShellEmulation
LayerShellEmulation->>QTimer: start()
deactivate LayerShellEmulation
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @yixinshark - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the lambda connected to
screenAddedinto a named method for better readability. - It looks like
m_exclusionZoneChangedTimer.start()is called twice when a screen is added, which is probably not what you want.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
reviewed
Apr 15, 2025
| }); | ||
| connect(qApp, &QGuiApplication::primaryScreenChanged, &m_exclusionZoneChangedTimer, static_cast<void (QTimer::*)()>(&QTimer::start)); | ||
| connect(m_window, &QWindow::screenChanged, this, [this](QScreen *nowScreen){ | ||
| onPositionChanged(); | ||
| m_exclusionZoneChangedTimer.start(); | ||
| }); | ||
|
|
||
| connect(qApp, &QGuiApplication::screenRemoved, &m_exclusionZoneChangedTimer, static_cast<void (QTimer::*)()>(&QTimer::start)); |
There was a problem hiding this comment.
这种插拔多次, 会重复连接吧,
是不是应该加上Qt::UniqueConnection,
as title Log: as title Pms: BUG-306339
yixinshark
force-pushed
the
fix-exclusionZone
branch
from
263b6df to
482efd1
Compare
deepin pr auto review关键摘要:
是否建议立即修改:
|
18202781743
approved these changes
Apr 15, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
Log: as title
Pms: BUG-306339
Summary by Sourcery
Update exclusion zone handling to trigger recalculation when screens are added or removed
Bug Fixes:
Enhancements: