-
Notifications
You must be signed in to change notification settings - Fork 7
just improvements for overriding commands & generating owl #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just improvements for overriding commands & generating owl #114
Conversation
15231f5 to
c3d230e
Compare
c3d230e to
8c27fd6
Compare
36d1b0e to
02b7d21
Compare
|
|
||
| # Overriding recipes from the root justfile by adding a recipe with the same | ||
| # name in an imported file is not possible until a known issue in just is fixed, | ||
| # https://github.com/casey/just/issues/2540 - So we need to override them here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| @if [ ! -d "{{dest}}/typescript" ]; then \ | ||
| mkdir -p {{dest}}/typescript ; \ | ||
| fi | ||
| uv run gen-typescript {{gen_ts_args}} {{source_schema_path}} > {{dest}}/typescript/{{schema_name}}.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point, we should move uv run to ${RUN}? but not a blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of || true feels like regression. My usage pattern is to use just setup many times during development because the non-just-setup workflow is unclear. See linkml/linkml-project-cookiecutter@887e10e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. We may add || true back. Does it fail for other reasons than the missing dir which is added now? (in the part below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reply @dalito
Actually ignore my comment.
I spent some time troubleshooting before I realized --vcs-ref main is needed - duh!! That keeps catching me.
Maybe the commit message should be changed but not failing now.
commit a32369546f2ac0346957182a80f07e44d429cbdf (HEAD -> main)
Author: noelmcloughlin <[email protected]>
Date: Mon Dec 8 22:30:52 2025 +0000
Initialise git with minimal project
commit 0dd78469240e4c6f70d6b39e931b821ea1a18b63
Author: noelmcloughlin <[email protected]>
Date: Mon Dec 8 22:30:41 2025 +0000
Initialise git with minimal project
commit 1f1ddd3fb3f1bee698144c6fbb15bbc51be5ad1f
Author: noelmcloughlin <[email protected]>
Date: Mon Dec 8 22:30:22 2025 +0000
Initialise git with minimal project
Two small changes to
distrib_schema_path) that should be deployed with the docs build.Update: Just issue casey/just#2540 prevents the straight-forward overwriting of recipes defined in the
justfilewith recipes from the importedproject.justfile. So it needs to be done differently.