Skip to content

Conversation

@dalito
Copy link
Member

@dalito dalito commented Nov 22, 2025

Two small changes to

  • Help users when overriding commands defined in the root justfile - You have to set the option that allows overrides! We shouldn't make users find that out for themselves.
  • Create directories for generators that cannot create them (owl & typescript), addresses Steps required to make this v1.0.0 #93
  • Add a general location variable for schema artifacts (distrib_schema_path) that should be deployed with the docs build.

Update: Just issue casey/just#2540 prevents the straight-forward overwriting of recipes defined in the justfile with recipes from the imported project.justfile. So it needs to be done differently.

@dalito dalito changed the title Just cmd improvements java and override just improvements for gen-java and for overriding commands Nov 22, 2025
@dalito dalito requested a review from sierra-moxon November 22, 2025 13:09
@dalito dalito marked this pull request as draft November 23, 2025 10:47
@dalito dalito force-pushed the just-cmd-improvements_java-and-override branch from 15231f5 to c3d230e Compare November 23, 2025 16:30
@dalito dalito added this to the Release 0.5.0 milestone Nov 23, 2025
@dalito dalito marked this pull request as ready for review November 23, 2025 17:24
@dalito dalito marked this pull request as draft November 23, 2025 19:51
@dalito dalito force-pushed the just-cmd-improvements_java-and-override branch from c3d230e to 8c27fd6 Compare November 23, 2025 21:09
@dalito dalito marked this pull request as ready for review November 23, 2025 22:29
@dalito dalito mentioned this pull request Nov 23, 2025
3 tasks
@dalito dalito changed the title just improvements for gen-java and for overriding commands just improvements for overriding commands & generating owl Nov 23, 2025
@dalito dalito force-pushed the just-cmd-improvements_java-and-override branch from 36d1b0e to 02b7d21 Compare November 23, 2025 23:22

# Overriding recipes from the root justfile by adding a recipe with the same
# name in an imported file is not possible until a known issue in just is fixed,
# https://github.com/casey/just/issues/2540 - So we need to override them here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@if [ ! -d "{{dest}}/typescript" ]; then \
mkdir -p {{dest}}/typescript ; \
fi
uv run gen-typescript {{gen_ts_args}} {{source_schema_path}} > {{dest}}/typescript/{{schema_name}}.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we should move uv run to ${RUN}? but not a blocker

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of || true feels like regression. My usage pattern is to use just setup many times during development because the non-just-setup workflow is unclear. See linkml/linkml-project-cookiecutter@887e10e

Copy link
Member Author

@dalito dalito Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. We may add || true back. Does it fail for other reasons than the missing dir which is added now? (in the part below)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reply @dalito
Actually ignore my comment.
I spent some time troubleshooting before I realized --vcs-ref main is needed - duh!! That keeps catching me.

Maybe the commit message should be changed but not failing now.

commit a32369546f2ac0346957182a80f07e44d429cbdf (HEAD -> main)
Author: noelmcloughlin <[email protected]>
Date:   Mon Dec 8 22:30:52 2025 +0000

    Initialise git with minimal project

commit 0dd78469240e4c6f70d6b39e931b821ea1a18b63
Author: noelmcloughlin <[email protected]>
Date:   Mon Dec 8 22:30:41 2025 +0000

    Initialise git with minimal project

commit 1f1ddd3fb3f1bee698144c6fbb15bbc51be5ad1f
Author: noelmcloughlin <[email protected]>
Date:   Mon Dec 8 22:30:22 2025 +0000

    Initialise git with minimal project

@sierra-moxon sierra-moxon merged commit 4ec9c0d into linkml:main Dec 5, 2025
2 checks passed
@dalito dalito deleted the just-cmd-improvements_java-and-override branch December 5, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants