Fixed naming

linkdotnet · linkdotnet · commit 73c300f48c63 · 2022-02-19T20:10:55.000+01:00
diff --git a/DecoratorPattern/CachedRepository.cs b/DecoratorPattern/CachedRepository.cs
@@ -13,11 +13,11 @@ public CachedRepository(IMemoryCache memoryCache, IRepository repository)
         _repository = repository;
     }
 
-    public async Task<Person> GetPersonById(int id)
+    public async Task<Person> GetPersonByIdAsync(int id)
     {
         if (!_memoryCache.TryGetValue(id, out Person value))
         {
-            value = await _repository.GetPersonById(id);
+            value = await _repository.GetPersonByIdAsync(id);
             _memoryCache.Set(id, value);
         }
 
diff --git a/DecoratorPattern/DecoratorPattern.sln b/DecoratorPattern/DecoratorPattern.sln
@@ -1,16 +1,16 @@
 ﻿
 Microsoft Visual Studio Solution File, Format Version 12.00
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DecoratorPattern", "DecoratorPattern.csproj", "{56D318E6-37DA-46A7-AE04-533A1254FE75}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DecoratorPattern", "DecoratorPattern.csproj", "{BCE46AF5-03BC-4FD3-88C6-3C5C5A5C3908}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
 		Release|Any CPU = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(ProjectConfigurationPlatforms) = postSolution
-		{56D318E6-37DA-46A7-AE04-533A1254FE75}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{56D318E6-37DA-46A7-AE04-533A1254FE75}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{56D318E6-37DA-46A7-AE04-533A1254FE75}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{56D318E6-37DA-46A7-AE04-533A1254FE75}.Release|Any CPU.Build.0 = Release|Any CPU
+		{BCE46AF5-03BC-4FD3-88C6-3C5C5A5C3908}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{BCE46AF5-03BC-4FD3-88C6-3C5C5A5C3908}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{BCE46AF5-03BC-4FD3-88C6-3C5C5A5C3908}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{BCE46AF5-03BC-4FD3-88C6-3C5C5A5C3908}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 EndGlobal
diff --git a/DecoratorPattern/IRepository.cs b/DecoratorPattern/IRepository.cs
@@ -2,7 +2,7 @@
 
 public interface IRepository
 {
-    public Task<Person> GetPersonById(int id);
+    public Task<Person> GetPersonByIdAsync(int id);
 
     public Task SavePersonAsync(Person person);
 }
diff --git a/DecoratorPattern/Program.cs b/DecoratorPattern/Program.cs
@@ -20,9 +20,9 @@
 await repository.SavePersonAsync(person);
 
 var stopwatch = Stopwatch.StartNew();
-await repository.GetPersonById(1);
+await repository.GetPersonByIdAsync(1);
 Console.WriteLine($"First call took {stopwatch.ElapsedMilliseconds} ms");
 
 stopwatch.Restart();
-await repository.GetPersonById(1);
+await repository.GetPersonByIdAsync(1);
 Console.WriteLine($"Second call took {stopwatch.ElapsedMilliseconds} ms");
diff --git a/DecoratorPattern/SlowRepository.cs b/DecoratorPattern/SlowRepository.cs
@@ -4,7 +4,7 @@ public class SlowRepository : IRepository
 {
     private readonly List<Person> _people = new();
 
-    public async Task<Person> GetPersonById(int id)
+    public async Task<Person> GetPersonByIdAsync(int id)
     {
         await Task.Delay(1000);
         return _people.Single(p => p.Id == id);

Original file line number	Diff line number	Diff line change
`@@ -13,11 +13,11 @@ public CachedRepository(IMemoryCache memoryCache, IRepository repository)`
`13`	`13`	`_repository = repository;`
`14`	`14`	`}`
`15`	`15`
`16`		`- public async Task<Person> GetPersonById(int id)`
	`16`	`+ public async Task<Person> GetPersonByIdAsync(int id)`
`17`	`17`	`{`
`18`	`18`	`if (!_memoryCache.TryGetValue(id, out Person value))`
`19`	`19`	`{`
`20`		`- value = await _repository.GetPersonById(id);`
	`20`	`+ value = await _repository.GetPersonByIdAsync(id);`
`21`	`21`	`_memoryCache.Set(id, value);`
`22`	`22`	`}`
`23`	`23`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`public interface IRepository`
`4`	`4`	`{`
`5`		`- public Task<Person> GetPersonById(int id);`
	`5`	`+ public Task<Person> GetPersonByIdAsync(int id);`
`6`	`6`
`7`	`7`	`public Task SavePersonAsync(Person person);`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ public class SlowRepository : IRepository`
`4`	`4`	`{`
`5`	`5`	`private readonly List<Person> _people = new();`
`6`	`6`
`7`		`- public async Task<Person> GetPersonById(int id)`
	`7`	`+ public async Task<Person> GetPersonByIdAsync(int id)`
`8`	`8`	`{`
`9`	`9`	`await Task.Delay(1000);`
`10`	`10`	`return _people.Single(p => p.Id == id);`