Skip to content

lnwire: start to write the type byte when encoding channel updates in failures #6461

@Roasbeef

Description

@Roasbeef

Initial implementations were somewhat split after a spec ambiguity, so we made a change to be able to read both versions (with and w/o the type byte).

A new spec PR proposes the we just write the type byte after all: lightning/bolts#979

On our end, we can start to write the type byte in the next version without worry that we're borking communication to older versions, since we're already able to read both versions. We can opt to use the generalized lnwire.WriteMessage function (which'll add that type byte), or we can just write 0x0102 (the channel update message type) before we encode an onion error.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions