You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
MigrateGraphToSQL comment incorrectly describes it as test-only
#11294
The comment on MigrateGraphToSQL says the function is currently called only from tests and will be called from the main lnd binary once the migration is fully implemented and tested.
However, in config_builder.go, when DB.UseNativeSQL is enabled and DB.SkipNativeSQLMigration is false:
The graphMig callback calls MigrateGraphToSQL.
This callback is assigned to the graph migration's MigrationFn.
The migration list is passed to NativeSQLStore.ApplyAllMigrations.
This appears to make the function reachable from the main lnd binary when the graph migration is pending.
The same comment and call path are present in the released v0.21.4-beta tag, as well as on master. The links above reference the release tag so the relevant code is tied to a specific version.
Am I understanding this call path correctly? If so, would removing or updating the test-only note be appropriate?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
The comment on MigrateGraphToSQL says the function is currently called only from tests and will be called from the main lnd binary once the migration is fully implemented and tested.
However, in config_builder.go, when DB.UseNativeSQL is enabled and DB.SkipNativeSQLMigration is false:
This appears to make the function reachable from the main lnd binary when the graph migration is pending.
The same comment and call path are present in the released v0.21.4-beta tag, as well as on master. The links above reference the release tag so the relevant code is tied to a specific version.
Am I understanding this call path correctly? If so, would removing or updating the test-only note be appropriate?
All reactions