Skip to content

Commit 8418383

Browse files
ffranrguggero
authored andcommitted
perms: move perms.go into taprpc
The Lightning Node Connect WASM client requires access to `perms.go` for RPC endpoint-related permissions. We move it into taprpc so that the WASM build only needs to depend on the taprpc module, without importing the entire taproot-assets module.
1 parent 0067c90 commit 8418383

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

server.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"github.com/lightninglabs/taproot-assets/address"
1818
"github.com/lightninglabs/taproot-assets/fn"
1919
"github.com/lightninglabs/taproot-assets/monitoring"
20-
"github.com/lightninglabs/taproot-assets/perms"
2120
"github.com/lightninglabs/taproot-assets/rfqmsg"
2221
"github.com/lightninglabs/taproot-assets/rpcperms"
2322
"github.com/lightninglabs/taproot-assets/tapchannel"
@@ -133,7 +132,7 @@ func (s *Server) initialize(interceptorChain *rpcperms.InterceptorChain) error {
133132
Checkers: []macaroons.Checker{
134133
macaroons.IPLockChecker,
135134
},
136-
RequiredPerms: perms.RequiredPermissions,
135+
RequiredPerms: taprpc.RequiredPermissions,
137136
},
138137
)
139138
if err != nil {
@@ -158,7 +157,7 @@ func (s *Server) initialize(interceptorChain *rpcperms.InterceptorChain) error {
158157

159158
// Register all our known permission with the macaroon
160159
// service.
161-
for method, ops := range perms.RequiredPermissions {
160+
for method, ops := range taprpc.RequiredPermissions {
162161
err := interceptorChain.AddPermission(
163162
method, ops,
164163
)
@@ -311,7 +310,7 @@ func (s *Server) RunUntilShutdown(mainErrChan <-chan error) error {
311310
serverOpts := s.cfg.GrpcServerOpts
312311

313312
// Get RPC endpoints which don't require macaroons.
314-
macaroonWhitelist := perms.MacaroonWhitelist(
313+
macaroonWhitelist := taprpc.MacaroonWhitelist(
315314
s.cfg.UniversePublicAccess.IsReadAccessGranted(),
316315
s.cfg.UniversePublicAccess.IsWriteAccessGranted(),
317316
s.cfg.RPCConfig.AllowPublicUniProofCourier,

taprpc/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ require (
77
github.com/lightningnetwork/lnd v0.19.0-beta.rc2.0.20250423092132-a35ace7371af
88
google.golang.org/grpc v1.64.1
99
google.golang.org/protobuf v1.34.2
10+
gopkg.in/macaroon-bakery.v2 v2.1.0
1011
)
1112

1213
require (
@@ -174,7 +175,6 @@ require (
174175
google.golang.org/genproto/googleapis/api v0.0.0-20240513163218-0867130af1f8 // indirect
175176
google.golang.org/genproto/googleapis/rpc v0.0.0-20240513163218-0867130af1f8 // indirect
176177
gopkg.in/errgo.v1 v1.0.1 // indirect
177-
gopkg.in/macaroon-bakery.v2 v2.0.1 // indirect
178178
gopkg.in/macaroon.v2 v2.0.0 // indirect
179179
gopkg.in/natefinch/lumberjack.v2 v2.0.0 // indirect
180180
gopkg.in/yaml.v2 v2.4.0 // indirect

taprpc/go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -728,8 +728,8 @@ gopkg.in/errgo.v1 v1.0.1/go.mod h1:3NjfXwocQRYAPTq4/fzX+CwUhPRcR/azYRhj8G+LqMo=
728728
gopkg.in/errgo.v2 v2.1.0/go.mod h1:hNsd1EY+bozCKY1Ytp96fpM3vjJbqLJn88ws8XvfDNI=
729729
gopkg.in/fsnotify.v1 v1.4.7/go.mod h1:Tz8NjZHkW78fSQdbUxIjBTcgA1z1m8ZHf0WmKUhAMys=
730730
gopkg.in/inconshreveable/log15.v2 v2.0.0-20180818164646-67afb5ed74ec/go.mod h1:aPpfJ7XW+gOuirDoZ8gHhLh3kZ1B08FtV2bbmy7Jv3s=
731-
gopkg.in/macaroon-bakery.v2 v2.0.1 h1:0N1TlEdfLP4HXNCg7MQUMp5XwvOoxk+oe9Owr2cpvsc=
732-
gopkg.in/macaroon-bakery.v2 v2.0.1/go.mod h1:B4/T17l+ZWGwxFSZQmlBwp25x+og7OkhETfr3S9MbIA=
731+
gopkg.in/macaroon-bakery.v2 v2.1.0 h1:9Jw/+9XHBSutkaeVpWhDx38IcSNLJwWUICkOK98DHls=
732+
gopkg.in/macaroon-bakery.v2 v2.1.0/go.mod h1:B4/T17l+ZWGwxFSZQmlBwp25x+og7OkhETfr3S9MbIA=
733733
gopkg.in/macaroon.v2 v2.0.0 h1:LVWycAfeJBUjCIqfR9gqlo7I8vmiXRr51YEOZ1suop8=
734734
gopkg.in/macaroon.v2 v2.0.0/go.mod h1:+I6LnTMkm/uV5ew/0nsulNjL16SK4+C8yDmRUzHR17I=
735735
gopkg.in/natefinch/lumberjack.v2 v2.0.0 h1:1Lc07Kr7qY4U2YPouBjpCLxpiyxIVoxqXgkXLknAOE8=

perms/perms.go renamed to taprpc/perms.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package perms
1+
package taprpc
22

33
import "gopkg.in/macaroon-bakery.v2/bakery"
44

0 commit comments

Comments
 (0)