Skip to content

Commit 143ee65

Browse files
committed
AddInvoice: expose field Private
Previously we'd always pass Private=true. Fix #207
1 parent 3e177ef commit 143ee65

File tree

2 files changed

+31
-3
lines changed

2 files changed

+31
-3
lines changed

lightning_client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1631,7 +1631,7 @@ func (s *lightningClient) AddInvoice(ctx context.Context,
16311631
DescriptionHash: in.DescriptionHash,
16321632
Expiry: in.Expiry,
16331633
CltvExpiry: in.CltvExpiry,
1634-
Private: true,
1634+
Private: in.Private,
16351635
}
16361636

16371637
if in.Preimage != nil {

lightning_client_test.go

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ func TestLightningClientAddInvoice(t *testing.T) {
6666
DescriptionHash: validAddInvoiceData.DescriptionHash,
6767
Expiry: validAddInvoiceData.Expiry,
6868
CltvExpiry: validAddInvoiceData.CltvExpiry,
69-
Private: true,
7069
}
7170

7271
validPayReq := "a valid pay req"
@@ -85,6 +84,22 @@ func TestLightningClientAddInvoice(t *testing.T) {
8584
return validResp, nil
8685
}
8786

87+
privateAddInvoiceData := *validAddInvoiceData
88+
privateAddInvoiceData.Private = true
89+
privateInvoice := &lnrpc.Invoice{
90+
Memo: validAddInvoiceData.Memo,
91+
RPreimage: validAddInvoiceData.Preimage[:],
92+
RHash: validAddInvoiceData.Hash[:],
93+
ValueMsat: int64(validAddInvoiceData.Value),
94+
DescriptionHash: validAddInvoiceData.DescriptionHash,
95+
Expiry: validAddInvoiceData.Expiry,
96+
CltvExpiry: validAddInvoiceData.CltvExpiry,
97+
Private: true,
98+
}
99+
privateAddInvoiceArgs := []addInvoiceArg{
100+
{in: privateInvoice},
101+
}
102+
88103
errorAddInvoice := func(in *lnrpc.Invoice, opts ...grpc.CallOption) (
89104
*lnrpc.AddInvoiceResponse, error) {
90105

@@ -119,7 +134,20 @@ func TestLightningClientAddInvoice(t *testing.T) {
119134
hash: validRHash,
120135
payRequest: validPayReq,
121136
},
122-
}, {
137+
},
138+
{
139+
name: "private invoice",
140+
client: mockRPCClient{
141+
addInvoice: validAddInvoice,
142+
},
143+
invoice: &privateAddInvoiceData,
144+
expect: expect{
145+
addInvoiceArgs: privateAddInvoiceArgs,
146+
hash: validRHash,
147+
payRequest: validPayReq,
148+
},
149+
},
150+
{
123151
name: "rpc client error",
124152
client: mockRPCClient{
125153
addInvoice: errorAddInvoice,

0 commit comments

Comments
 (0)