Use latest artifact upload/download action versions

Author: arik-so

.github/actions/upload-xcframework-artifact/action.yml

@@ -14,7 +14,7 @@ runs:
                 python3 ./scripts/symlink_resolver.py /Users/runner/work/ldk-swift/ldk-swift/bindings/bin/release/LightningDevKit-no-symlinks.xcframework
                 ditto -c -k --sequesterRsrc --keepParent /Users/runner/work/ldk-swift/ldk-swift/bindings/bin/release/LightningDevKit-no-symlinks.xcframework LightningDevKit-no-symlinks.xcframework.zip
         -   name: Upload Framework Artifact
-            uses: actions/upload-artifact@v3
+            uses: actions/upload-artifact@v4
             with:
                 name: LightningDevKit
                 path: |

.github/workflows/build-xcframework-parallel-archives.yml

@@ -57,9 +57,9 @@ jobs:
             -   name: Xcarchive hack
                 run: touch ./bindings_root.txt
             -   name: Upload xcarchive
-                uses: actions/upload-artifact@v3
+                uses: actions/upload-artifact@v4
                 with:
-                    name: bindings
+                    name: bindings-${{ matrix.configuration['human_readable_platform'] }}
                     path: ./bindings/**/bin/release/${{ matrix.configuration['human_readable_platform'] }}/${{ matrix.configuration['human_readable_platform'] }}.xcarchive
 
     generate:
@@ -77,7 +77,17 @@ jobs:
             -   name: Checkout
                 uses: actions/checkout@v3
             -   name: Download xcarchives
-                uses: actions/download-artifact@v3
+                uses: actions/download-artifact@v4
+                with:
+                    merge-multiple: true
+                    path: ./bindings
+            -   name: Print post-artifact-download directory structure
+                shell: bash
+                run: |
+                    echo "Current path:"
+                    pwd
+                    echo "Recursive enumeration"
+                    find "$PWD"
             -   name: Generate xcframework
                 shell: bash
                 run:

.github/workflows/build-xcframework-parallel-libldk.yml

@@ -65,9 +65,9 @@ jobs:
                     LLVM_TARGET_TRIPLE_SUFFIX: ${{ matrix.configuration['llvm_target_triple_suffix'] }}
                     ARCHS: ${{ matrix.configuration['architectures'] }}
             -   name: Upload binary
-                uses: actions/upload-artifact@v3
+                uses: actions/upload-artifact@v4
                 with:
-                    name: bindings
+                    name: bindings-${{ matrix.configuration['human_readable_platform'] }}
                     path: |
                         ./bindings/**/artifacts/ldk-c-bindings/lightning-c-bindings/include/*.h
                         ./bindings/**/artifacts/ldk-c-bindings/ldk-net/ldk_net.*
@@ -87,7 +87,17 @@ jobs:
             -   name: Checkout
                 uses: actions/checkout@v3
             -   name: Download libldks
-                uses: actions/download-artifact@v3
+                uses: actions/download-artifact@v4
+                with:
+                    merge-multiple: true
+                    path: ./bindings
+            -   name: Print post-artifact-download directory structure
+                shell: bash
+                run: |
+                    echo "Current path:"
+                    pwd
+                    echo "Recursive enumeration"
+                    find "$PWD"
             -   name: Generate Swift Bindings
                 shell: bash
                 run: |

.github/workflows/test-artifacts.yml

@@ -32,7 +32,7 @@ jobs:
                     mkdir -p ./bindings/bin/release/${{ matrix.configuration['human_readable_platform'] }}
                     touch ./bindings/bin/release/${{ matrix.configuration['human_readable_platform'] }}/${{ matrix.configuration['human_readable_platform'] }}.xcarchive
             -   name: Upload emulated xcarchive
-                uses: actions/upload-artifact@v3
+                uses: actions/upload-artifact@v4
                 with:
                     name: uploaded-artifact-name
                     path: ./bindings/**/bin/release/${{ matrix.configuration['human_readable_platform'] }}/${{ matrix.configuration['human_readable_platform'] }}.xcarchive