Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service worker generation? #3

Open
ol-web opened this issue Jan 27, 2018 · 2 comments
Open

service worker generation? #3

ol-web opened this issue Jan 27, 2018 · 2 comments

Comments

@ol-web
Copy link

ol-web commented Jan 27, 2018

create-react-app has it, google's abandoned web starter kit has it.

i really like this starter kit so adding new features would be pretty neat. i really like how react can turn a basic web app into a PWA without doing anything.

btw i'd be nice to see webpack-dev-server host a server on the local network the same way create-react-app does. i just added my ip to the --host flag to webpack-dev-server in npm start but it would be nice to see this starter kit do it automatically out of the box.

@lifenautjoe
Copy link
Owner

Hey Michal,

Thanks for the suggestion :)

Do you mean generating a service worker for offline caching?

On exposing the dev server on the local area network, I'll add an npm script to do it.

@ol-web
Copy link
Author

ol-web commented Jan 28, 2018

Yeah, offline caching and the ability to add the website to the phone's homescreen. create-react-app has service worker generation that does everything automatically, the developer only needs to worry about meeting the PWA checklist criteria(such as https) for the web app to have all these magical functionalities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants