Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This lacks any documentation.... #108

Open
MrJake222 opened this issue Apr 24, 2023 · 2 comments
Open

This lacks any documentation.... #108

MrJake222 opened this issue Apr 24, 2023 · 2 comments

Comments

@MrJake222
Copy link

I don't even know what the functions are returning... Particularly extended functions. I want to implement circular buffer for mp3 data and It seems the functions don't return how many bytes they consumed...
@tosone
Copy link

tosone commented Apr 25, 2023

Maybe you can see here: https://github.com/tosone/minimp3/blob/main/decode.go#L10

MrJake222 added a commit to MrJake222/minimp3 that referenced this issue Apr 25, 2023
@MrJake222
Written some docs, to my best understanding
2c5d16e 
Relates to lieff#108
@MrJake222 MrJake222 mentioned this issue Apr 25, 2023
Open
@MrJake222
Copy link
Author

Hi, sadly, examples aren't documentation. I've written some basic docstrings, to my best understanding. Now I can get my program using limited circular buffer to work. But i didn't document all. See PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tosone @MrJake222