fix: linter

Author: vgorkavenko

src/constants.py

@@ -1,8 +1,6 @@
 from packaging.version import Version
 
 from src.types import Gwei
-from src.variables import STAKING_MODULE_ADDRESS
-
 # https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/beacon-chain.md#misc
 FAR_FUTURE_EPOCH = 2**64 - 1
 # https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/beacon-chain.md#time-parameters-1

src/main.py

@@ -12,7 +12,7 @@
 
 
 def main(module: OracleModule):
-    # pylint: disable=import-outside-toplevel
+    # pylint: disable=import-outside-toplevel,too-many-return-statements
 
     if module is OracleModule.CHECK:
         errors = variables.check_uri_required_variables()

src/modules/checks/suites/common.py

@@ -63,4 +63,3 @@ def check_csm_contract_configs(csm):
 def check_cm_contract_configs(cm):
     """Make sure cm contract configs are valid"""
     cm.check_contract_configs()
-

src/modules/oracles/common/oracle_module.py

@@ -49,6 +49,7 @@ def run_cycle(self, last_finalized_blockstamp: BlockStamp):
 
     @contextmanager
     def exception_handler(self) -> Iterator[None]:
+        # pylint: disable=too-many-branches
         """Context manager for handling Oracle module cycle exceptions"""
         try:
             yield
@@ -86,7 +87,6 @@ def exception_handler(self) -> Iterator[None]:
         except ValueError as error:
             logger.error({'msg': 'Unexpected error.', 'error': str(error)})
         except Exception as error:
-            # Перебрасываем неизвестные исключения
             raise error
 
     @abstractmethod

src/modules/oracles/staking_modules/base.py

@@ -1,6 +1,5 @@
 import atexit
 import logging
-from abc import abstractmethod
 
 from hexbytes import HexBytes
 
@@ -55,22 +54,17 @@ class SMPerformanceOracle(OracleModule):
         3. Calculate the share of each node operator excluding underperforming validators.
     """
 
-    @property
-    @abstractmethod
-    def COMPATIBLE_CONTRACT_VERSION(self) -> int:
-        """Contract version this oracle is compatible with"""
-        raise NotImplementedError
-
-    @property
-    @abstractmethod
-    def COMPATIBLE_CONSENSUS_VERSION(self) -> int:
-        """Consensus version this oracle is compatible with"""
-        raise NotImplementedError
+    COMPATIBLE_CONTRACT_VERSION: int = 0
+    COMPATIBLE_CONSENSUS_VERSION: int = 0
 
     report_contract: CSFeeOracleContract
     state: State
 
     def __init__(self, w3: Web3):
+        if self.COMPATIBLE_CONTRACT_VERSION == 0:
+            raise ValueError("CONTRACT_VERSION is not defined")
+        if self.COMPATIBLE_CONSENSUS_VERSION == 0:
+            raise ValueError("CONSENSUS_VERSION is not defined")
         self.consumer = self.__class__.__name__
         self.report_contract = w3.staking_module.oracle
         self.state = State.load(self.consumer)

src/modules/oracles/staking_modules/common/state.py

@@ -118,7 +118,8 @@ def load(cls, oracle_name: str) -> Self:
                 if not obj:
                     raise ValueError("Got empty object")
                 # Ensure loaded object has the correct oracle_name
-                if hasattr(obj, "_oracle_name") and obj._oracle_name != oracle_name:
+                # pylint: disable=protected-access
+                if obj._oracle_name != oracle_name:
                     logger.warning({
                         "msg": f"Cache oracle name mismatch: {obj._oracle_name} != {oracle_name}. Creating new state."
                     })

src/web3py/extensions/staking_module.py

@@ -161,4 +161,4 @@ def has_contract_address_changed(self) -> bool:
         return False
 
     def reload_contracts(self) -> None:
-        self._load_contracts()
+        self._load_contracts()

tests/fork/test_csm_oracle_cycle.py

@@ -100,16 +100,16 @@ def missed_initial_frame(frame_config: FrameConfig, cycle_iterations):
     'module',
     [
         csm_module,
-        #cm_module
+        # cm_module
     ],
     indirect=True,
 )
 @pytest.mark.parametrize(
     'running_finalized_slots',
     [
-        #start_before_initial_epoch,
+        # start_before_initial_epoch,
         start_after_initial_epoch,
-        #missed_initial_frame
+        # missed_initial_frame
     ],
     indirect=True,
 )

tests/modules/csm/test_csm_distribution.py

@@ -12,7 +12,11 @@
     MIN_ACTIVATION_BALANCE,
     EFFECTIVE_BALANCE_INCREMENT,
 )
-from src.modules.oracles.staking_modules.common.distribution import Distribution, ValidatorDuties, ValidatorDutiesOutcome
+from src.modules.oracles.staking_modules.common.distribution import (
+    Distribution,
+    ValidatorDuties,
+    ValidatorDutiesOutcome,
+)
 from src.modules.oracles.staking_modules.common.log import FramePerfLog, ValidatorFrameSummary, OperatorFrameSummary
 from src.modules.oracles.staking_modules.common.state import DutyAccumulator, State, NetworkDuties, Frame
 from src.modules.oracles.staking_modules.common.types import StrikesList
@@ -297,7 +301,9 @@ def test_calculate_distribution(
     expected_strikes,
 ):
     # Mocking the data from EL
-    w3 = Mock(spec=Web3, staking_module=Mock(spec=StakingModuleContracts, fee_distributor=Mock(spec=CSFeeDistributorContract)))
+    w3 = Mock(
+        spec=Web3, staking_module=Mock(spec=StakingModuleContracts, fee_distributor=Mock(spec=CSFeeDistributorContract))
+    )
     w3.staking_module.fee_distributor.shares_to_distribute = Mock(side_effect=shares_to_distribute)
     w3.staking_module.get_curve_params = mocked_curve_params
 
@@ -323,7 +329,9 @@ def test_calculate_distribution(
 @pytest.mark.unit
 def test_calculate_distribution_handles_invalid_distribution():
     # Mocking the data from EL
-    w3 = Mock(spec=Web3, staking_module=Mock(spec=StakingModuleContracts, fee_distributor=Mock(spec=CSFeeDistributorContract)))
+    w3 = Mock(
+        spec=Web3, staking_module=Mock(spec=StakingModuleContracts, fee_distributor=Mock(spec=CSFeeDistributorContract))
+    )
     w3.staking_module.fee_distributor.shares_to_distribute = Mock(return_value=500)
     w3.staking_module.get_curve_params = Mock(...)
 
@@ -351,7 +359,9 @@ def test_calculate_distribution_handles_invalid_distribution():
 @pytest.mark.unit
 def test_calculate_distribution_handles_invalid_distribution_in_total():
     # Mocking the data from EL
-    w3 = Mock(spec=Web3, staking_module=Mock(spec=StakingModuleContracts, fee_distributor=Mock(spec=CSFeeDistributorContract)))
+    w3 = Mock(
+        spec=Web3, staking_module=Mock(spec=StakingModuleContracts, fee_distributor=Mock(spec=CSFeeDistributorContract))
+    )
     w3.staking_module.fee_distributor.shares_to_distribute = Mock(return_value=500)
     w3.staking_module.get_curve_params = Mock(...)
 

tests/modules/csm/test_csm_module.py

@@ -270,7 +270,9 @@ def test_set_epochs_range_to_collect_posts_new_demand(module: CSPerformanceOracl
 
 
 @pytest.mark.unit
-def test_set_epochs_range_to_collect_skips_post_when_demand_same(module: CSPerformanceOracle, mock_chain_config: NoReturn):
+def test_set_epochs_range_to_collect_skips_post_when_demand_same(
+    module: CSPerformanceOracle, mock_chain_config: NoReturn
+):
     blockstamp = ReferenceBlockStampFactory.build()
     module.state = Mock(migrate=Mock(), log_progress=Mock())
     converter = Mock()