Fix BSP.split_recursive crash when passing Random

Random was passed directly to CFFI instead of fetching its C pointer

Fixes #168

Author: HexDecimal

tcod/bsp.py

@@ -148,20 +148,17 @@ def split_recursive(  # noqa: PLR0913
         """Divide this partition recursively.
 
         Args:
-            depth (int): The maximum depth to divide this object recursively.
-            min_width (int): The minimum width of any individual partition.
-            min_height (int): The minimum height of any individual partition.
-            max_horizontal_ratio (float):
-                Prevent creating a horizontal ratio more extreme than this.
-            max_vertical_ratio (float):
-                Prevent creating a vertical ratio more extreme than this.
-            seed (Optional[tcod.random.Random]):
-                The random number generator to use.
+            depth: The maximum depth to divide this object recursively.
+            min_width: The minimum width of any individual partition.
+            min_height: The minimum height of any individual partition.
+            max_horizontal_ratio: Prevent creating a horizontal ratio more extreme than this.
+            max_vertical_ratio: Prevent creating a vertical ratio more extreme than this.
+            seed: The random number generator to use.
         """
         cdata = self._as_cdata()
         lib.TCOD_bsp_split_recursive(
             cdata,
-            seed or ffi.NULL,
+            seed.random_c if seed is not None else ffi.NULL,
             depth,
             min_width,
             min_height,

tests/test_tcod.py

@@ -9,7 +9,12 @@
 from numpy.typing import DTypeLike, NDArray
 
 import tcod
+import tcod.bsp
 import tcod.console
+import tcod.context
+import tcod.map
+import tcod.path
+import tcod.random
 from tcod import libtcodpy
 
 
@@ -20,7 +25,7 @@ def raise_Exception(*_args: object) -> NoReturn:
 def test_line_error() -> None:
     """Test exception propagation."""
     with pytest.raises(RuntimeError), pytest.warns():
-        tcod.line(0, 0, 10, 10, py_callback=raise_Exception)
+        libtcodpy.line(0, 0, 10, 10, py_callback=raise_Exception)
 
 
 @pytest.mark.filterwarnings("ignore:Iterate over nodes using")
@@ -44,7 +49,7 @@ def test_tcod_bsp() -> None:
 
     # test that operations on deep BSP nodes preserve depth
     sub_bsp = bsp.children[0]
-    sub_bsp.split_recursive(3, 2, 2, 1, 1)
+    sub_bsp.split_recursive(3, 2, 2, 1, 1, seed=tcod.random.Random(seed=42))
     assert sub_bsp.children[0].level == 2  # noqa: PLR2004
 
     # cover find_node method