Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed Mac binary (via Carthage) depends on Homebrew’d openssl #667

Open
mxcl opened this issue Sep 27, 2018 · 5 comments
Open

Distributed Mac binary (via Carthage) depends on Homebrew’d openssl #667

mxcl opened this issue Sep 27, 2018 · 5 comments

Comments

@mxcl
Copy link

mxcl commented Sep 27, 2018

$ otool -L ObjectiveGit.framework/ObjectiveGit 
ObjectiveGit:
	@rpath/ObjectiveGit.framework/ObjectiveGit (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libcurl.4.dylib (compatibility version 7.0.0, current version 9.0.0)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
	/System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa (compatibility version 1.0.0, current version 22.0.0)
	/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 1452.23.0)
	/usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.50.4)
	/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1452.23.0)

Key lines being these:

/usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)

This makes it hard to distribute a binary on Mac that uses ObjectiveGit.

I realize this is probably a deep seated distribution problem, I'm willing to put in the time to fix it, but need guidance and encouragement. Thanks.

@tiennou
Copy link
Contributor

tiennou commented Sep 27, 2018

Hey, another GitX fork, which stumbled on the exact same problem I did just a few days ago 😉.

@mxcl Can you give a try to the PR just above, just so I have another pair of eyes ?

@mxcl
Copy link
Author

mxcl commented Sep 28, 2018

Great! I’ll do it. Will let you know.

@mxcl
Copy link
Author

mxcl commented Sep 28, 2018

This didn't work for my GitX installation since it runs in the ObjectiveGit.framework build and at that point there is no bundle to copy the dylibs to.

@tiennou
Copy link
Contributor

tiennou commented Sep 28, 2018

I've just checked my GitX by moving the submodule against that, and I can confirm its included ObjectiveGit.framework is correct, and it runs.

  • Did the script error in some way while building ObjectiveGit ?
  • Can you provide the output of otool -L against your GitX executable, and it's ObjectiveGit framework ?
  • How is your build system setup, is it submodules or carthage/CocoaPods ?

@mxcl
Copy link
Author

mxcl commented Sep 28, 2018

K right I see how it can work. I built with Carthage on CLI. So that is no good yeah. But if you build as source from the GitX project it makes sense that it would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants