New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate ignore rule methods #435

Open

josharian opened this issue Feb 22, 2018 · 0 comments

Contributor

josharian commented Feb 22, 2018

Repository methods include:

func (r *Repository) AddGitIgnoreRules(rules string) error
func (v *Repository) AddIgnoreRule(rules string) error
func (r *Repository) ClearGitIgnoreRules() error
func (v *Repository) ClearInternalIgnoreRules() error

The implementation is almost identical.

I suggest marking one of each of the pairs as deprecated, and having it just call through to its sibling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment