Skip to content

Commit 6d1ac57

Browse files
JoshKisbJoshKisb
committed
show product
1 parent 1c0ee64 commit 6d1ac57

File tree

4 files changed

+85
-38
lines changed

4 files changed

+85
-38
lines changed

‎app/Http/Controllers/ProductController.php

+25-25
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,30 @@ public function index(Request $request)
2626
return view('products.index', compact('products'));
2727
}
2828

29+
public function show(Product $product)
30+
{
31+
// // Track browsing history
32+
// if (auth()->check()) {
33+
// BrowsingHistory::create([
34+
// 'user_id' => auth()->id(),
35+
// 'product_id' => $product->id,
36+
// ]);
37+
// }
38+
39+
// // Get recommendations
40+
// $recommendations = [];
41+
// if (auth()->check()) {
42+
// $recommendations = $this->recommendationService->getRecommendations(auth()->user());
43+
// }
44+
45+
// $metaTitle = $product->meta_title ?? $product->name;
46+
// $metaDescription = $product->meta_description ?? $product->short_description;
47+
// $metaKeywords = $product->meta_keywords;
48+
// $canonicalUrl = route('products.show', ['category' => $category, 'product' => $product->slug]);
49+
50+
return view('products.show', compact('product'));
51+
}
52+
2953
public function create(Request $request)
3054
{
3155
// Handle Product File Upload
@@ -60,31 +84,7 @@ public function create(Request $request)
6084

6185

6286

63-
public function show($category, Product $product)
64-
{
65-
// $product = Product::where('id', $product)->firstOrFail();
66-
67-
// Track browsing history
68-
if (auth()->check()) {
69-
BrowsingHistory::create([
70-
'user_id' => auth()->id(),
71-
'product_id' => $product->id,
72-
]);
73-
}
74-
75-
// Get recommendations
76-
$recommendations = [];
77-
if (auth()->check()) {
78-
$recommendations = $this->recommendationService->getRecommendations(auth()->user());
79-
}
80-
81-
$metaTitle = $product->meta_title ?? $product->name;
82-
$metaDescription = $product->meta_description ?? $product->short_description;
83-
$metaKeywords = $product->meta_keywords;
84-
$canonicalUrl = route('products.show', ['category' => $category, 'product' => $product->slug]);
85-
86-
return view('products.show', compact('product', 'recommendations', 'metaTitle', 'metaDescription', 'metaKeywords', 'canonicalUrl'));
87-
}
87+
8888

8989
public function update(Request $request, $id)
9090
{

‎database/factories/ProductFactory.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@
1111
*/
1212
class ProductFactory extends Factory
1313
{
14-
14+
/**
15+
* The name of the factory's corresponding model.
16+
*
17+
* @var class-string<\Illuminate\Database\Eloquent\Model>
18+
*/
1519
protected $model = Product::class;
1620
/**
1721
* Define the model's default state.

‎routes/web.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,11 @@
6868
// Product routes
6969
Route::get('/products', [ProductController::class, 'index'])->name('products.index');
7070
Route::post('/products', [ProductController::class, 'store'])->name('products.store');
71+
Route::get('/products/{product}', [ProductController::class, 'show'])->name('products.show');
7172
Route::get('/products/create', [ProductController::class, 'create'])->name('products.create');
7273
Route::get('/products/search', [ProductController::class, 'search'])->name('products.search');
7374

74-
Route::get('/product/{category}/{product}', [ProductController::class, 'show'])->name('products.show');
75+
// Route::get('/product/{category}/{product}', [ProductController::class, 'show'])->name('products.show');
7576
Route::put('/product/{category}/{product}', [ProductController::class, 'update'])->name('products.update');
7677
Route::patch('/product/{category}/{product}', [ProductController::class, 'update']);
7778
Route::delete('/product/{category}/{product}', [ProductController::class, 'delete'])->name('products.delete');

‎tests/Feature/Frontend/ProductControllerTest.php

+53-11
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace Tests\Feature\Frontend;
44

5+
use App\Models\Product;
56
use Tests\TestCase;
67
use Illuminate\Foundation\Testing\RefreshDatabase;
78

@@ -15,28 +16,69 @@ public function test_list_products_empty()
1516
$response = $this->get(route('products.index'));
1617

1718
$response->assertStatus(200);
18-
// $response->assertViewIs('products.index');
19-
// $response->assertViewHas('products', function ($products) {
20-
// return $products->isEmpty();
21-
// });
19+
$response->assertViewIs('products.index');
20+
$response->assertViewHas('products', function ($products) {
21+
return $products->isEmpty();
22+
});
2223
}
2324

24-
private function test_list_products_with_one_product()
25+
// Test listing products with one product
26+
public function test_list_products_with_one_product()
2527
{
26-
// Test logic here
28+
$productName = "Test Product";
29+
$product = Product::factory()->create([
30+
"name" => $productName
31+
]);
32+
33+
$response = $this->get(route('products.index'));
34+
35+
$response->assertStatus(200);
36+
$response->assertViewIs('products.index');
37+
$response->assertViewHas('products', function ($products) use ($product, $productName) {
38+
return (
39+
$products->count() === 1
40+
&& $products->first()->id === $product->id
41+
&& $products->first()->name === $productName
42+
);
43+
});
2744
}
2845

29-
private function test_list_products_with_multiple_products()
46+
47+
// Test listing products with multiple products
48+
public function test_list_products_with_multiple_products()
3049
{
31-
// Test logic here
50+
$products = Product::factory()->count(3)->sequence(
51+
["name" => "Product 1"],
52+
["name" => "Product 2"],
53+
["name" => "Product 3"]
54+
)->create();
55+
56+
$response = $this->get(route('products.index'));
57+
58+
$response->assertStatus(200);
59+
$response->assertViewIs('products.index');
60+
$response->assertViewHas('products', function ($viewProducts) use ($products) {
61+
if ($viewProducts->count() !== 3) {
62+
return false;
63+
}
64+
65+
$viewProductNames = $viewProducts->pluck('name');
66+
$productNames = $products->pluck('name');
67+
68+
return $productNames->every(fn ($name) => $viewProductNames->contains($name));
69+
});
3270
}
3371

34-
// Test showing a single product
35-
private function test_show_product_returns_404_for_non_existent_product()
72+
73+
// Test showing a single product returns 404 for non-existent product
74+
public function test_show_product_returns_404_for_non_existent_product()
3675
{
37-
// Test logic here
76+
$response = $this->get(route('products.show', ['product' => 999]));
77+
78+
$response->assertStatus(404);
3879
}
3980

81+
4082
private function test_show_product_returns_correct_product()
4183
{
4284
// Test logic here

0 commit comments

Comments
 (0)