Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

When rebasing an accepted PR lgtm requires another webhook call to update #22

Open
frapposelli opened this issue Jun 8, 2016 · 2 comments

Comments

@frapposelli
Copy link

Steps to reproduce:

  • Open a PR
  • LGTM it (status check turns green)
  • Rebase and (force) push to fork
  • Status check is reset
  • Add a comment (not necessary a LGTM)
  • Status check turns green again.

What I'd like to happen:

  • Open a PR
  • LGTM it (status check turns green)
  • Rebase and (force) push to fork
  • Status check is still green
@bradrydzewski
Copy link
Member

At first glance I'm guessing GitHub must reset the status checks because LGTM doesn't receive pull_request hooks, only issue hooks. Will have to dig deeper though to fully understand

@aaronjensen
Copy link

I just pushed a new commit, didn't even rebase and it didn't update status until I left a comment. This was on flycheck/flycheck#1063

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants