Commit b986780
committed
docs(ai): state the still-failing case's reachability durably
Two comments justified the `Fail → Fail` Warn arm by saying `--refresh-baseline`
writes the current report verbatim with no `any_fail` check. That was true when
written and is about to stop being true: phase-rs#7029 adds exactly that check. Both
comments would then assert, in the tree, a property the tree no longer has — and
because they are comments, nothing would fail. They would simply be wrong.
The conclusion they support is unaffected, so only the justification changes.
`Fail → Fail` stays reachable no matter what guards the write path, because
nothing revalidates a committed baseline when it is loaded: a baseline blessed
before the guard, or hand-edited, still carries the failure. That reason is true
before and after phase-rs#7029, which is the property a durable comment needs.
Found by sweeping this branch's own claims against a branch in flight, rather
than against the current tree — an instrument that came from review catching the
same shape one layer down, where a doc comment in phase-rs#7029 asserted the paired arm
"never consults `status`", true at that head and false here.
Four surfaces carried the claim: both comments, the commit message of the first
commit on this branch, and the PR body. The commit message is deliberately left
alone — this repo squash-merges, so branch messages do not survive to the tree,
and a force-push to reword a doomed message would churn review for no durable
effect. The PR body is corrected in place, and the source comments here.
Assisted-by: ClaudeCode:claude-opus-51 parent 52fbc5a commit b986780
1 file changed
Lines changed: 14 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
410 | 410 | | |
411 | 411 | | |
412 | 412 | | |
413 | | - | |
414 | | - | |
415 | | - | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
416 | 421 | | |
417 | 422 | | |
418 | 423 | | |
| |||
1445 | 1450 | | |
1446 | 1451 | | |
1447 | 1452 | | |
1448 | | - | |
1449 | | - | |
1450 | | - | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
1451 | 1459 | | |
1452 | 1460 | | |
1453 | 1461 | | |
| |||
0 commit comments