Skip to content

Commit 2228f0d

Browse files
committed
fix: negative fraction not simplified correctly
1 parent b3e7a3f commit 2228f0d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

content/tools/trigonometrie/trigonometrie.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ class Fraction {
161161
static VALUE = 1;
162162

163163
constructor(numerator, denominator) {
164+
// don't simplify too early
164165
this._numerator = numerator;
165166
this._denominator = denominator;
166167
this._simplify();
@@ -189,7 +190,9 @@ class Fraction {
189190
}
190191

191192
_simplify() {
192-
const divisor = gcd(this.numerator, this.denominator);
193+
let divisor = gcd(this.numerator, this.denominator);
194+
if (this._denominator < 0)
195+
divisor = -divisor;
193196
this._numerator /= divisor;
194197
this._denominator /= divisor;
195198
}

0 commit comments

Comments
 (0)