Skip to content

consul: Add consul health checking for all gRPC endpoints #8261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

consul: Add consul health checking for all gRPC endpoints #8261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e0f5518
grpc: Enable client-side health_v1 health checking
beautifulentropy Jun 16, 2025
8c3ea92
Fix log lines and test
beautifulentropy Jun 16, 2025
7f42517
Remove empty line
beautifulentropy Jun 16, 2025
4ea0d57
Add consul healthchecking for all gRPC endpoints
beautifulentropy Jun 17, 2025
831440c
Order clientNames in JSON
beautifulentropy Jun 17, 2025
61bb5d5
Construct a deduped slice and directly modify ClientNames
beautifulentropy Jun 17, 2025
1d0efc3
Reverting Consul changes for now, it's too flaky in CI
beautifulentropy Jun 17, 2025
b593665
consul: Enable health checking for all gRPC endpoints
beautifulentropy Jun 17, 2025
ffcb484
Merge branch 'main' into consul-grpc-health
beautifulentropy Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/config-next/akamai-purger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/ca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/crl-storer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/email-exporter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/nonce-a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/nonce-b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/publisher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/ra.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/remoteva-a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/remoteva-b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/remoteva-c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
4 changes: 2 additions & 2 deletions test/config-next/sa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"health-checker.boulder",
"consul.boulder"
"consul.boulder",
"health-checker.boulder"
]
}
}
Expand Down
1 change: 1 addition & 0 deletions test/config-next/va.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/akamai-purger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/ca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/crl-storer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/email-exporter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/nonce-a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/nonce-b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/publisher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/ra.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/remoteva-a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/remoteva-b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
1 change: 1 addition & 0 deletions test/config/remoteva-c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
4 changes: 2 additions & 2 deletions test/config/sa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"health-checker.boulder",
"consul.boulder"
"consul.boulder",
"health-checker.boulder"
]
}
}
Expand Down
1 change: 1 addition & 0 deletions test/config/va.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
},
"grpc.health.v1.Health": {
"clientNames": [
"consul.boulder",
"health-checker.boulder"
]
}
Expand Down
Loading