Merge pull request #242 from lesstif/pr/239

fixed Pr/239

Author: lesstif

.env.example

@@ -1,5 +1,6 @@
 JIRA_HOST="https://your-jira.host.com"
 JIRA_USER="jira-username"
 JIRA_PASS="jira-password"
+JIRA_LOG_ENABLED=true
 JIRA_LOG_FILE="jira-rest-client.log"
 JIRA_LOG_LEVEL="WARNING"

src/Configuration/AbstractConfiguration.php

@@ -28,6 +28,13 @@ abstract class AbstractConfiguration implements ConfigurationInterface
      */
     protected $jiraPassword;
 
+    /**
+     * Enabled write to log.
+     *
+     * @var bool
+     */
+    protected $jiraLogEnabled;
+
     /**
      * Path to log file.
      *
@@ -143,6 +150,14 @@ public function getJiraPassword()
         return $this->jiraPassword;
     }
 
+    /**
+     * @return bool
+     */
+    public function getJiraLogEnabled()
+    {
+        return $this->jiraLogEnabled;
+    }
+
     /**
      * @return string
      */

src/Configuration/ArrayConfiguration.php

@@ -18,6 +18,7 @@ class ArrayConfiguration extends AbstractConfiguration
      */
     public function __construct(array $configuration)
     {
+        $this->jiraLogEnabled = true;
         $this->jiraLogFile = 'jira-rest-client.log';
         $this->jiraLogLevel = 'WARNING';
         $this->curlOptSslVerifyHost = false;

src/Configuration/ConfigurationInterface.php

@@ -34,6 +34,13 @@ public function getJiraUser();
      */
     public function getJiraPassword();
 
+    /**
+     * Enabled write to log.
+     *
+     * @return bool
+     */
+    public function getJiraLogEnabled();
+
     /**
      * Path to log file.
      *

src/Configuration/DotEnvConfiguration.php

@@ -24,6 +24,7 @@ public function __construct($path = '.')
         $this->oauthAccessToken = $this->env('OAUTH_ACCESS_TOKEN');
         $this->cookieAuthEnabled = $this->env('COOKIE_AUTH_ENABLED', false);
         $this->cookieFile = $this->env('COOKIE_FILE', 'jira-cookie.txt');
+        $this->jiraLogEnabled = $this->env('JIRA_LOG_ENABLED', true);
         $this->jiraLogFile = $this->env('JIRA_LOG_FILE', 'jira-rest-client.log');
         $this->jiraLogLevel = $this->env('JIRA_LOG_LEVEL', 'WARNING');
         $this->curlOptSslVerifyHost = $this->env('CURLOPT_SSL_VERIFYHOST', false);

src/JiraClient.php

@@ -59,7 +59,7 @@ class JiraClient
      * Constructor.
      *
      * @param ConfigurationInterface $configuration
-     * @param Logger                 $logger
+     * @param LoggerInterface        $logger
      * @param string                 $path
      *
      * @throws JiraException
@@ -86,14 +86,19 @@ public function __construct(ConfigurationInterface $configuration = null, Logger
         $this->json_mapper->classMap['\\'.\DateTimeInterface::class] = \DateTime::class;
 
         // create logger
-        if ($logger) {
-            $this->log = $logger;
+        if ($this->configuration->getJiraLogEnabled()) {
+            if ($logger) {
+                $this->log = $logger;
+            } else {
+                $this->log = new Logger('JiraClient');
+                $this->log->pushHandler(new StreamHandler(
+                    $this->configuration->getJiraLogFile(),
+                    $this->convertLogLevel($this->configuration->getJiraLogLevel())
+                ));
+            }
         } else {
             $this->log = new Logger('JiraClient');
-            $this->log->pushHandler(new StreamHandler(
-                $this->configuration->getJiraLogFile(),
-                $this->convertLogLevel($this->configuration->getJiraLogLevel())
-            ));
+            $this->log->pushHandler(new NoOperationMonologHandler());
         }
 
         $this->http_response = 200;

src/NoOperationMonologHandler.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace JiraRestApi;
+
+use Monolog\Handler\AbstractProcessingHandler;
+
+class NoOperationMonologHandler extends AbstractProcessingHandler
+{
+    /**
+     * Writes the record down to the log of the implementing handler.
+     *
+     * @param array $record
+     *
+     * @return void
+     */
+    protected function write(array $record)
+    {
+        // do nothing
+    }
+}