Skip to content

Commit 5a04438

Browse files
committed
Issue #227: Board integration coding standards.
1 parent 0b31bb3 commit 5a04438

File tree

3 files changed

+42
-33
lines changed

3 files changed

+42
-33
lines changed

src/Board/Board.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,39 +33,39 @@ class Board implements \JsonSerializable
3333
*/
3434
public function getId()
3535
{
36-
return $this->id;
36+
return $this->id;
3737
}
3838

3939
/**
4040
* Get board url.
4141
*/
4242
public function getSelf()
4343
{
44-
return $this->self;
44+
return $this->self;
4545
}
4646

4747
/**
4848
* Get board name.
4949
*/
5050
public function getName()
5151
{
52-
return $this->name;
52+
return $this->name;
5353
}
5454

5555
/**
5656
* Get board type.
5757
*/
5858
public function getType()
5959
{
60-
return $this->type;
60+
return $this->type;
6161
}
6262

6363
/**
6464
* Get location.
6565
*/
6666
public function getLocation()
6767
{
68-
return $this->location;
68+
return $this->location;
6969
}
7070

7171
public function jsonSerialize()

src/Board/BoardService.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,25 @@ public function __construct(ConfigurationInterface $configuration = null, Logger
2626
*/
2727
public function getBoardList($paramArray = [])
2828
{
29-
$json = $this->exec($this->uri. $this->toHttpQueryParameter($paramArray), null);
29+
$json = $this->exec($this->uri.$this->toHttpQueryParameter($paramArray), null);
3030
$boards = $this->json_mapper->mapArray(
3131
json_decode($json)->values, new \ArrayObject(), Board::class
3232
);
3333
return $boards;
3434
}
3535

36-
public function getBoard($id, $paramArray = []) {
37-
$json = $this->exec($this->uri . '/' . $id . $this->toHttpQueryParameter($paramArray), null);
36+
public function getBoard($id, $paramArray = [])
37+
{
38+
$json = $this->exec($this->uri.'/'.$id.$this->toHttpQueryParameter($paramArray), null);
3839
$board = $this->json_mapper->map(
3940
json_decode($json), new Board()
4041
);
4142
return $board;
4243
}
4344

44-
public function getBoardIssues($id, $paramArray = []) {
45-
$json = $this->exec($this->uri . '/' . $id . $this->toHttpQueryParameter($paramArray), null);
45+
public function getBoardIssues($id, $paramArray = [])
46+
{
47+
$json = $this->exec($this->uri.'/'.$id . $this->toHttpQueryParameter($paramArray), null);
4648
$board = $this->json_mapper->mapArray(
4749
json_decode($json), new \ArrayObject(), Issue::class
4850
);

src/Board/Location.php

Lines changed: 30 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2,76 +2,83 @@
22

33
namespace JiraRestApi\Board;
44

5-
class Location implements \JsonSerializable {
6-
7-
/** @var int **/
5+
class Location implements \JsonSerializable
6+
{
7+
/** @var int * */
88
public $projectId;
99

10-
/** @var string **/
10+
/** @var string * */
1111
public $displayName;
1212

13-
/** @var string **/
13+
/** @var string * */
1414
public $projectName;
1515

16-
/** @var string **/
16+
/** @var string * */
1717
public $projectKey;
1818

19-
/** @var string **/
19+
/** @var string * */
2020
public $projectTypeKey;
2121

22-
/** @var string **/
22+
/** @var string * */
2323
public $avatarUri;
2424

25-
/** @var string **/
25+
/** @var string * */
2626
public $name;
2727

2828
/**
2929
* Get project id.
3030
*/
31-
public function getProjectId() {
32-
return $this->projectId;
31+
public function getProjectId()
32+
{
33+
return $this->projectId;
3334
}
3435

3536
/**
3637
* Get project id.
3738
*/
38-
public function getDisplayName() {
39-
return $this->displayName;
39+
public function getDisplayName()
40+
{
41+
return $this->displayName;
4042
}
4143

4244
/**
4345
* Get project name.
4446
*/
45-
public function getProjectName() {
46-
return $this->projectName;
47+
public function getProjectName()
48+
{
49+
return $this->projectName;
4750
}
4851

4952
/**
5053
* Get project key.
5154
*/
52-
public function getProjectKey() {
53-
return $this->projectKey;
55+
public function getProjectKey()
56+
{
57+
return $this->projectKey;
5458
}
5559

5660
/**
5761
* Get project type key.
5862
*/
59-
public function getProjectTypeKey() {
60-
return $this->projectTypeKey;
63+
public function getProjectTypeKey()
64+
{
65+
return $this->projectTypeKey;
6166
}
6267

6368
/**
6469
* Get avatar uri.
6570
*/
66-
public function getAvatarUri() {
67-
return $this->avatarUri;
71+
public function getAvatarUri()
72+
{
73+
return $this->avatarUri;
6874
}
6975

7076
/**
7177
* Get name.
7278
*/
73-
public function getName() {
74-
return $this->name;
79+
public function getName()
80+
{
81+
return $this->name;
7582
}
7683

7784
/**

0 commit comments

Comments
 (0)