Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design:type metadata not created for decorated getter/setter #5

Open
mzeiher opened this issue Apr 1, 2019 · 2 comments
Open

design:type metadata not created for decorated getter/setter #5

mzeiher opened this issue Apr 1, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@mzeiher
Copy link

mzeiher commented Apr 1, 2019

sample:

@decorator()
get value(): string { ... }

set value(value:string) {}

Typescript annotates the getter/setter with design:type: String for the property "value", the plugin detects it as a method and only annotates design:paramtype if you are decorating the settter, if you are decorating the getter no type information are set.

@mzeiher mzeiher changed the title design:type metadata not created for deocrated getter/setter design:type metadata not created for decorated getter/setter Apr 1, 2019
@leonardfactory
Copy link
Owner

Interesting, didn’t think about that! I’ll add the feature in these days

@leonardfactory leonardfactory added the bug Something isn't working label Jul 25, 2019
@stephtr
Copy link

stephtr commented Jan 5, 2020

In case someone else is looking for a workaround, until then you could add a @Reflect.metadata("design:type", String) decorator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants