Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperable filters should be treated as separable #39

Open
leios opened this issue Dec 31, 2022 · 0 comments
Open

Seperable filters should be treated as separable #39

leios opened this issue Dec 31, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@leios
Copy link
Owner

leios commented Dec 31, 2022

The Gaussian blur filter (for example), can be changed to be a blur along x, transpose, then blur along y (and transpose again). This might be more efficient in the end.

It's best if users give just a 1D filter and say it's separable. We can then call a separate separable_filter(...) function, which does the filter!(...), transpose(), and filter!(...), like we do for sobel.

note, this is related to #38, which introduces filtering.

@leios leios added the enhancement New feature or request label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant