-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device current volume #193
Comments
I propose instead of creating a whole new sensor we fetch the volume data and save in a "generic" device sensor that can collect all such data. We currently have |
Alarm volume is more related to alarms sensor, IMO. I'd add it there. |
Oh right, I was actually getting confused between two concepts: alarm/timer volume and device volume. The alarm/timers volume defs should go into alarm/timer sensor, but do we have a way to tweak device volume like playback volume? 🤔 |
The current volume also applies to timer volume. My two cents would be to have a generic sensor to hold misc things. The few things left to implement using the local API are things like the Equalizer levels. If that's something that's ever wanted, then having them in a device sensor makes sense |
Yes. You can change the normal volume using the cast integration. I use this to change the do not disturb settings and lower volume when I go to sleep and reset when I wake up |
Well, if alarm volume is also applied to timers volume, let's add it to Device volume is a different setting as I understand it. But it should be possible to set it as well. |
Exactly. So as proposed earlier we could for now just have those 'common' stuff under |
Should alarm volume just be an attribute then? And then keep tokens as state or should we move token to an attribute instead? I think volume is probably more useful 😊 |
I think we should make token an attribute and state should be something like device available (maybe ip address)/unavailable. |
Yeh i agree with the state being ip address or unavailable while both token and volume being attributed :) |
But i think right now that fixing the bugs is more important. On a side note, i am also spending sometime rewriting my card to be able to take advantage of the new features and want to catch up there before we implement more 😊 |
Yeah, this is defininely not urgent 🙂 |
Not that important indeed, but I do not like my device token to be directly visible in the automatic GUI. I also think the default status when no timers or alarms should be None or something and not Unavailable |
Yeah, it's done through Eureka, not tested, but seems like the correct approach, take a look at GHLAPI There's a parameter for volume, I assume that's playback volume. |
The alarm volume attribute has been added to the |
Edit: I have tried asking google "what's your alarm volume" and "what's your current volume" and she replied two different values. It indeed has two separate setting for google device volume and alarm volumes. |
@leikoilja yes it does indeed. I believe there is some info about it in here |
Would also be great to know the current alarm volume in either another sensor or as part of an attribute of another sensor
Originally posted by @gary-reyes in #192 (comment)
The text was updated successfully, but these errors were encountered: