fixed bug updated mailer config and routes

Author: lebronbrian23

.env.example

@@ -48,14 +48,12 @@ REDIS_HOST=127.0.0.1
 REDIS_PASSWORD=null
 REDIS_PORT=6379
 
-MAIL_MAILER=log
-MAIL_SCHEME=null
-MAIL_HOST=127.0.0.1
+MAIL_MAILER=smtp
+MAIL_HOST=smtp.mailtrap.io
 MAIL_PORT=2525
-MAIL_USERNAME=null
-MAIL_PASSWORD=null
-MAIL_FROM_ADDRESS="hello@example.com"
-MAIL_FROM_NAME="${APP_NAME}"
+MAIL_USERNAME=da3e53ae576a10
+MAIL_PASSWORD=5b10f30bdaa9b8
+MAIL_FROM_NAME1="${APP_NAME}"
 
 AWS_ACCESS_KEY_ID=
 AWS_SECRET_ACCESS_KEY=

.github/workflows/tests.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: '22'
+          node-version: '22.12'
           cache: 'npm'
 
       - name: Install Node Dependencies

app/Events/TaskCompleted.php

@@ -20,7 +20,7 @@ class TaskCompleted
      */
     public function __construct( public Task $task)
     {
-        //
+
     }
 
     /**

app/Http/Controllers/TaskController.php

@@ -126,7 +126,7 @@ public function update(UpdateTaskRequest $request, Task $task)
         ]);
 
         if ( $update_task->status === 'completed' ) {
-            log::info('Task completed email dispatched');
+            log::info('Task completed email dispatched here!');
             TaskCompleted::dispatch($update_task);
         }
 

app/Listeners/SendTaskCompletionEmail.php

@@ -3,18 +3,20 @@
 namespace App\Listeners;
 
 use App\Events\TaskCompleted;
+use App\Mail\SendTaskCompletionEmail as SendTaskCompletionMail;
+use App\Models\User;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Queue\InteractsWithQueue;
-use Illuminate\Support\Facades\Log;
+use Illuminate\Support\Facades\Mail;
+
 
 class SendTaskCompletionEmail
 {
     /**
      * Create the event listener.
      */
-    public function __construct()
-    {
-        //
+    public function __construct(){
+
     }
 
     /**
@@ -23,7 +25,9 @@ public function __construct()
     public function handle(TaskCompleted $event): void
     {
         //
-
-        log::info($event);
+        $user = User::where('id' , $event->task->user_id)->first();
+        if ($user) {
+            Mail::to($user->email)->send(new SendTaskCompletionMail($event->task));
+        }
     }
 }

app/Mail/SendTaskCompletionEmail.php

@@ -15,7 +15,6 @@ class SendTaskCompletionEmail extends Mailable
     use Queueable, SerializesModels;
 
     protected $task;
-    private $task_url;
 
     /**
      * Create a new message instance.
@@ -45,7 +44,7 @@ public function content(): Content
         return new Content(
             markdown: 'mail.task.completion',
             with: [
-                'url' => $this->task_url
+                'url' => route('get-task-id',$this->task->id)
             ],
         );
     }

config/mail.php

@@ -14,8 +14,7 @@
     |
     */
 
-    'default' => env('MAIL_MAILER', 'log'),
-
+    'default' => env('MAIL_MAILER', 'smtp'),
     /*
     |--------------------------------------------------------------------------
     | Mailer Configurations

routes/api.php

@@ -1,47 +1,31 @@
 <?php
 
-
 use App\Http\Controllers\ProductController;
 use App\Http\Controllers\TaskController;
 use App\Models\User;
 
-
-/*Route::controller(ProductController::class)->group( function () {
-
+Route::controller(ProductController::class)->group(function () {
     Route::get('/products', 'index')->name('products');
     Route::get('/get-product/{id}','show')->name('get-product-id');
-    Route::post('/add-product' , 'store')->name('add-product');
-    Route::get('/add-product-form' , 'create')->name('add-product-form');
-    Route::get('/edit-product-form/{id}' , 'edit')->name('edit-product-form-id');
+    Route::post('/add-product', 'store')->name('add-product');
+    Route::get('/add-product-form', 'create')->name('product-add-form');
+    Route::get('/edit-product-form/{id}', 'edit')->name('edit-product-form-id');
     Route::put('/update-product', 'update')->name('update-product');
     Route::delete('/delete-product/{id}','destroy')->name('delete-product-id');
     Route::post('/upload-photo','upload_image')->name('add_product_photo');
-});*/
+});
 
-Route::controller(TaskController::class)->group( function() {
+Route::controller(TaskController::class)->group(function() {
     Route::get('/tasks', 'index')->name('tasks');
     Route::get('/get-tasks', 'getTasks')->name('get-tasks');
     Route::get('/get-user-tasks/{user_id}', 'getTasks')->name('get-user-tasks');
     Route::get('/task','show')->name('show-task');
     Route::get('/get-task/{id}','getTask')->name('get-task-id');
-    Route::get('/add-task', 'create')->name('add-task-form');
+    Route::get('/add-task', 'create')->name('task-add-form');
     Route::post('/add-task', 'store')->name('save-task');
     Route::get('/edit-task/{task}','edit')->name('edit-task-form');
     Route::put('/update-task/{task}', 'update')->name('update-task');
     Route::delete('/delete-task/{task}', 'destroy')->name('delete-task-id');
-    Route::put('/restore-task/{id}', 'restore')->name('restore-task-id');
-    Route::delete('/delete-task-permanently/{id}', 'destroy_permanently')->name('delete-task-permanently-id');
-
-});
-//Route::middleware('auth:sanctum')->group( function () {
-//    Route::get('/user', function (Request $request){
-//        return User::find(1);
-//    });
-//
-//    Route::get('/get-users',  'getusers');
-//    Route::post('/add-user',  'addUser');
-//    Route::put('/update-user',  'update');
-//    Route::delete('/delete-user', 'destroy');
-//
-//});
-
+    Route::put('/restore-task/{task}', 'restore')->name('restore-task-id');
+    Route::delete('/delete-task-permanently/{task}', 'destroy_permanently')->name('delete-task-permanently-id');
+});

tests/Feature/ProductTest.php

@@ -12,18 +12,11 @@
 
 class ProductTest extends TestCase
 {
-    public function test_returns_a_successful_response()
-    {
-        $response = $this->get(route('home'));
-
-        $response->assertStatus(200);
-    }
-
-    //use RefreshDatabase;
+    use RefreshDatabase;
 
     /**
      *  Test if products index returns the expected static list
-     *
+     */
     public function test_can_list_products()
     {
         $response = $this->get(route('products'));
@@ -36,7 +29,7 @@ public function test_can_list_products()
             ]);
             /*->assertJsonFragment(['id' => 1, 'name' => 'matooke', 'origin' => 'uganda'])
             ->assertJsonFragment(['id' => 2, 'name' => 'rice', 'origin' => 'india'])
-            ->assertJsonFragment(['id' => 3, 'name' => 'beans', 'origin' => 'burundi']);*
+            ->assertJsonFragment(['id' => 3, 'name' => 'beans', 'origin' => 'burundi']);*/
 
         // Ensure exactly 3 products are returned
         $data = $response->json();
@@ -46,15 +39,15 @@ public function test_can_list_products()
 
     /**
         Test if add product form shows
-     *
+     */
     public function test_can_show_add_product_form() {
-        $response = $this->get(route('add-product-form'));
+        $response = $this->get(route('product-add-form'));
         $response->assertStatus(200);
 
     }
     /**
      * Test if a product can be added
-     *
+     */
     public function test_can_add_product()
     {
 
@@ -72,7 +65,7 @@ public function test_can_add_product()
 
     /**
      *  Test if an image can be uploaded
-     *
+     */
     public function test_can_upload_image()
     {
         Storage::fake('public');
@@ -106,12 +99,11 @@ public function test_product_name_is_required()
 
     /**
      * Test if edit product form shows
-     *
+     */
     public function test_can_show_edit_product_form()
     {
         $id = random_int(1,4);
         $response = $this->get(route('edit-product-form-id',$id));
         $response->assertStatus(200);
     }
-      */
 }

tests/Feature/TaskTest.php

@@ -111,7 +111,7 @@ public function test_guest_cannot_view_tasks()
      * Test that a form to create a task displays
      */
     public function test_can_show_create_task_form(){
-        $response = $this->get(route('add-task-form'));
+        $response = $this->get(route('task-add-form'));
         $response->assertStatus(200);
     }