Skip to content

Commit f0bf024

Browse files
committed
style fixes
1 parent d048ce0 commit f0bf024

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

lud4ik/tests/test_command.py

+5
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,11 @@ def test_ackfinish(self):
6262
self.assertIsInstance(Packet.unpack(packet.pack()[self.LENGTH:]),
6363
AckFinish)
6464

65+
def test_without_fields(self):
66+
with self.assertRaises(FieldDeclarationError):
67+
class ErrorClass(Packet):
68+
pass
69+
6570
def test_without_cmd(self):
6671
with self.assertRaises(FieldDeclarationError):
6772
class ErrorClass(Packet):

lud4ik/work/protocol.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,8 @@ def __init__(self, name, bases, dct):
2424
if isinstance(value, Field):
2525
value.name = attr
2626
self.fields[attr] = value
27-
try:
28-
if not isinstance(next(iter(self.fields.values())), Cmd):
29-
raise FieldDeclarationError('Command shoud be first field.')
30-
except StopIteration:
27+
28+
if not (self.fields and isinstance(next(iter(self.fields.values())), Cmd)):
3129
raise FieldDeclarationError('Command shoud be first field.')
3230

3331
self.__class__.packets[cmd.id] = self

0 commit comments

Comments
 (0)