fix frontend bug

Author: taoerman

contentcuration/contentcuration/frontend/channelEdit/components/sidePanels/SubmitToCommunityLibrarySidePanel/__tests__/SubmitToCommunityLibrarySidePanel.spec.js

@@ -34,6 +34,9 @@ async function makeWrapper({ channel, publishedData, latestSubmission }) {
   const isLoading = ref(true);
   const isFinished = ref(false);
 
+  store.state.currentChannel.currentChannelId = channel.id;
+  store.commit('channel/ADD_CHANNEL', channel);
+
   usePublishedData.mockReturnValue({
     isLoading,
     isFinished,
@@ -74,9 +77,9 @@ const publishedNonPublicChannel = {
 };
 
 const publicChannel = {
-  id: 'published-non-public-channel',
+  id: 'public-channel',
   version: 2,
-  name: 'Published Non-Public Channel',
+  name: 'Public Channel',
   published: true,
   public: true,
 };
@@ -105,6 +108,10 @@ const publishedData = {
 const submittedLatestSubmission = { channel_version: 2, status: CommunityLibraryStatus.PENDING };
 
 describe('SubmitToCommunityLibrarySidePanel', () => {
+  beforeEach(() => {
+    store.state.currentChannel.currentChannelId = null;
+    store.state.channel.channelsMap = {};
+  });
   describe('correct warnings are shown', () => {
     it('when channel is published, not public and not submitted', async () => {
       const wrapper = await makeWrapper({
@@ -377,7 +384,7 @@ describe('SubmitToCommunityLibrarySidePanel', () => {
       });
 
       const descriptionTextbox = wrapper.findComponent('.description-textbox');
-      expect(descriptionTextbox.props('disabled')).toBe(false);
+      expect(descriptionTextbox.props('disabled')).toBe(true);
     });
   });
 
@@ -466,6 +473,7 @@ describe('SubmitToCommunityLibrarySidePanel', () => {
     });
 
     it('the panel closes', async () => {
+      jest.useFakeTimers();
       const wrapper = await makeWrapper({
         channel: publishedNonPublicChannel,
         publishedData,
@@ -479,9 +487,11 @@ describe('SubmitToCommunityLibrarySidePanel', () => {
       await submitButton.trigger('click');
 
       expect(wrapper.emitted('close')).toBeTruthy();
+      jest.useRealTimers();
     });
 
     it('a submission snackbar is shown', async () => {
+      jest.useFakeTimers();
       const wrapper = await makeWrapper({
         channel: publishedNonPublicChannel,
         publishedData,
@@ -493,14 +503,15 @@ describe('SubmitToCommunityLibrarySidePanel', () => {
 
       const submitButton = wrapper.find('[data-test="submit-button"]');
       await submitButton.trigger('click');
-
-      jest.useFakeTimers();
+      await wrapper.vm.$nextTick();
 
       expect(store.getters['snackbarIsVisible']).toBe(true);
       expect(CommunityLibrarySubmission.create).not.toHaveBeenCalled();
+      jest.useRealTimers();
     });
 
     it('the submission is created after a timeout', async () => {
+      jest.useFakeTimers();
       const wrapper = await makeWrapper({
         channel: publishedNonPublicChannel,
         publishedData,
@@ -512,20 +523,22 @@ describe('SubmitToCommunityLibrarySidePanel', () => {
 
       const countryField = wrapper.findComponent(CountryField);
       await countryField.vm.$emit('input', ['Czech Republic']);
-
-      jest.useFakeTimers();
+      await wrapper.vm.$nextTick();
 
       const submitButton = wrapper.find('[data-test="submit-button"]');
       await submitButton.trigger('click');
+      await wrapper.vm.$nextTick();
 
       jest.runAllTimers();
+      await wrapper.vm.$nextTick();
 
       expect(CommunityLibrarySubmission.create).toHaveBeenCalledWith({
         description: 'Some description',
         channel: publishedNonPublicChannel.id,
         countries: ['CZ'],
         categories: [Categories.SCHOOL],
       });
+      jest.useRealTimers();
     });
   });
 

contentcuration/contentcuration/frontend/channelEdit/components/sidePanels/SubmitToCommunityLibrarySidePanel/index.vue

@@ -99,8 +99,8 @@
           <div class="channel-title">
             {{
               channelVersion$({
-                name: currentChannel?.name || '',
-                version: currentChannel?.version || 0,
+                name: currentChannel ? currentChannel.name : '',
+                version: currentChannel ? currentChannel.version : 0,
               })
             }}
           </div>
@@ -158,11 +158,7 @@
             :label="confirmReplacementText$()"
             data-test="replacement-confirmation-checkbox"
             class="replacement-checkbox"
-            @change="
-              value => {
-                replacementConfirmed = value;
-              }
-            "
+            @change="onReplacementChange"
           />
         </div>
       </template>
@@ -434,6 +430,10 @@
         return store.dispatch('showSnackbar', params);
       }
 
+      function onReplacementChange(value) {
+        replacementConfirmed.value = value;
+      }
+
       function onSubmit() {
         // It should be possible to undo a submission within a short time window
         // in case the user made a mistake and wants to change something.
@@ -477,6 +477,7 @@
         countries,
         description,
         replacementConfirmed,
+        onReplacementChange,
         latestSubmissionIsLoading,
         latestSubmissionIsFinished,
         latestSubmissionStatus,