add nki.isa.gather_flattened #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongweiy
requested review from
govereau,
jiancheng-aws,
joonwonc,
jtristan,
ppotapov-aws,
seanmcl and
waahm7
as code owners
Collaborator
jiancheng-aws
left a comment
jiancheng-aws
left a comment
There was a problem hiding this comment.
I think you might want to run lake build Extract to have the code generation for e.g. serde
jiancheng-aws
requested changes
Nov 22, 2025
Collaborator
jiancheng-aws
left a comment
jiancheng-aws
left a comment
There was a problem hiding this comment.
I think you might want to run lake build Extract to have the code generation for e.g. serde
Collaborator
Yup, generate the C++ code and then we can merge. |
yongweiy
force-pushed
the
yy/gather-scattered
branch
from
ec02584 to
daad58c
Compare
Collaborator
Author
|
Including the C++ code. Thank you both. |
govereau
approved these changes
Nov 24, 2025
yongweiy
force-pushed
the
yy/gather-scattered
branch
2 times, most recently
from
8d85ffb to
33a7f13
Compare
ggumen
approved these changes
Nov 26, 2025
jiancheng-aws
approved these changes
Nov 26, 2025
ppotapov-aws
approved these changes
Dec 1, 2025
ppotapov-aws
force-pushed
the
yy/gather-scattered
branch
from
33a7f13 to
e885eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.