Skip to content

[NKIFE-465] Enable tracing of nki.isa APIs #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pratikfegade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NKIFE-465] Enable tracing of nki.isa APIs #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion KLR/Trace/Term.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,6 @@ def builtinEnv : List (Name × Term) := Id.run do
let fn := .builtin name none
Copy link
Collaborator

@waahm7 waahm7 Nov 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not merge this change until we are 100% sure that it's not breaking anything in NKI. One example of breaking change is that neuron_isa.py doesn't have nisa.dma_compute. Please coordinate with Yongwei Yuan.

Copy link
Collaborator Author

@pratikfegade pratikfegade Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. this change is blocked until I can iron out all issues on the NeuronKernelInterface and KaenaCompiler end of things.

Copy link
Collaborator

@yongweiy yongweiy Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change will break NKI; see NKIFE-506. Meanwhile, I am going through ISA.lean and neuron_isa.py to make sure APIs are consistent.

let names : List Name := match name with
| .str `builtin.python n => [.str `builtins n, .str .anonymous n]
| .str `builtin.isa n => [nisa n, name]
| .str `builtin.typing n => [nt n, name]
| .str `builtin.lang n => [nl n, name]
| _ => [name]
Expand Down
Loading