bf:generationDate domain should be bf:GenerationProcess

[kirkhess]

See https://id.loc.gov/ontologies/bibframe.html#p_generationDate

The example has:

<bf:Instance rdf:about="http://id.loc.gov/resources/instances/5226" >
<bf:generationProcess >
<bf:GenerationProcess >
<rdfs:label >DLC marc2bibframe2 v2.3.0</rdfs:label>
<bf:generationDate rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime" >2023-11-08T13:17:30.842291-05:00</bf:generationDate>
</bf:GenerationProcess>
</bf:generationProcess>
</bf:Instance>

But the ontology has <rdfs:domain rdf:resource="http://id.loc.gov/ontologies/bibframe/AdminMetadata"/> We had corrected GenerationProcess so it wasn't a subclass of AdminMetadata but this property didn't get updated - it should be
<rdfs:domain rdf:resource="http://id.loc.gov/ontologies/bibframe/GenerationProcess"/> (or no domain...)

I would suggest changing the example so it uses the same example as the property/class e.g.https://id.loc.gov/ontologies/bibframe.html#p_generationProcess.

[ntra00]

this generation date property hasn't changed since 2016:

https://id.loc.gov/ontologies/bibframe/generationDate.rdf

But you are right; it's not inside GenerationProcess.

https://github.com/lcnetdev/marc2bibframe2/blob/cdff84cf049834bb6f9035a773b1b8a9d4935e41/xsl/marc2bibframe2.xsl#L143-L154

Maybe it should be? It's arguably about the generation process.

[kirkhess]

<bf:Instance >
<bf:adminMetadata >
<bf:AdminMetadata >
<bf:generationProcess >
<bf:GenerationProcess >
<rdfs:label >DLC marc2bibframe2 v2.5.0</rdfs:label>
<bf:generationDate rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime" >2024-01-31T16:56:49.446832-05:00</bf:generationDate>
</bf:GenerationProcess>
</bf:generationProcess>
...

I put the example from my link above - it seems like fix is to remove the domain or change it to bf:GenerationProcess. These examples are a huge improvement, thanks for doing this!

BIBFRAME is a lot closer to MARC now that it was back in 2016. In this case, in bibframe2marc the label is the 884$a, generated by marc2bibframe2, the bf:generationDate is the 884$g date is a timestamp generated by the marc2bibframe2 conversion, the local identifier 884$k and the 884$q value are external parameters which are used by bibframe2marc. This shape makes sense but doesn't really translate to OWL or SHACL - maybe you can add a comment about the shape.

[klngwll]

I was under the impression the purpose of generationDate was that it could be used alongside a linked GenerationProcess [1]. If the need is to make this construction more annotation-like you could also simply use the regular date property [2]?

Example 1

<xyz> a bf:AdminMetadata ;
  bf:generationProcess <GenerationProcessX> ;
  bf:generationDate "2024-01-31T16:56:49.446832-05:00" .

<GenerationProcessX> a bf:GenerationProcess ;
  rdfs:label "DLC marc2bibframe2 v2.5.0" ;
  rdfs:seeAlso "https://github.com/lcnetdev/marc2bibframe2/releases/tag/v2.5.0" .

Example 2

<xyz> a bf:AdminMetadata ;
  bf:generationProcess [ a bf:GenerationProcess ;
    bf:date "2024-01-31T16:56:49.446832-05:00" ;
    rdfs:label "DLC marc2bibframe2 v2.5.0" ] .