Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Comment test results on PR when action is run #37

Open
pottekkat opened this issue Aug 17, 2021 · 5 comments
Open

Comment test results on PR when action is run #37

pottekkat opened this issue Aug 17, 2021 · 5 comments
Labels
issue/willfix This issue will be worked on kind/enhancement Improvement in current feature

Comments

@pottekkat
Copy link
Contributor

Current Behavior

Users are able to run SMI Conformance tests in their CI/CD pipelines and view the percentage of the tests passed in Meshery.

Desired Behavior

Comment the result of the test in the PR which the test was ran on.

This would require the action to be run on every push. This is solely based on the project requirement and would depend on how the projects actually use the action.


Contributor Guide

@pottekkat pottekkat added the kind/enhancement Improvement in current feature label Aug 17, 2021
@stale
Copy link

stale bot commented Oct 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 1, 2021
@pottekkat pottekkat added issue/willfix This issue will be worked on and removed issue/stale Issue has not had any activity for an extended period of time labels Oct 7, 2021
@keithmattix
Copy link

As a middle ground, perhaps there could be a flag to log the actual test output in the GH Action? It would be useful to see what particular aspect of the conformance tests are failing

@pottekkat
Copy link
Contributor Author

@keithmattix Yes. We will add that in mesheryctl and update the action. I will open up an issue in the Meshery repo as well.

@keithmattix
Copy link

@navendu-pottekkat I did some bash trickery to emulate this on a fork of the SMI action: it basically just switches between some background processes. I also had to set the PLATFORM variable equal to "docker" to make it work with the latest version of meshery.

@pottekkat
Copy link
Contributor Author

@DelusionalOptimist We are in need of updating the action.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/willfix This issue will be worked on kind/enhancement Improvement in current feature
Development

No branches or pull requests

2 participants