Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed lazy load from the slider settings #5806

Closed
wants to merge 1 commit into from

Conversation

H-A-R-S-H-K
Copy link
Contributor

This PR fixes #5805

Updated Behaviour:

Screen.Recording.2024-08-13.at.11.23.42.AM.mov

@l5io
Copy link
Contributor

l5io commented Aug 13, 2024

🚀 Preview for commit 0c1eb61 at: https://66baf8cea9b1dbbe7df8c76c--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 13, 2024

🚀 Preview for commit d6d36a4 at: https://66bb15d466193ed5f6f3f56b--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@H-A-R-S-H-K, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@Ashparshp
Copy link
Contributor

@H-A-R-S-H-K, have we discussed this in the meeting?

@H-A-R-S-H-K
Copy link
Contributor Author

@Ashparshp Yes we discussed that this needed to be fixed.

@hargunkaur286 hargunkaur286 self-requested a review August 22, 2024 11:15
@hargunkaur286
Copy link
Member

Thank you for your contribution @H-A-R-S-H-K LGTM!

@@ -10,7 +10,6 @@ import "slick-carousel/slick/slick-theme.css";

const settings = {
initialSlide: 1,
lazyLoad: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why lazyload is being a issue here. Lazy loading is kind of important because we don't want to hinder the experience of users if the images taking time to load. So why lazy loading is creating a issue here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@H-A-R-S-H-K @Ashparshp are either of you investigating this?

@Ashparshp
Copy link
Contributor

@H-A-R-S-H-K, any updates?

@sudhanshutech
Copy link
Member

@H-A-R-S-H-K checking in once again.

@H-A-R-S-H-K H-A-R-S-H-K deleted the slider-update branch September 24, 2024 02:43
@H-A-R-S-H-K
Copy link
Contributor Author

Sorry for the delayed response. Was busy for a while and I couldn't get a work around this issue so that's why closing the PR.

@Ashparshp
Copy link
Contributor

@H-A-R-S-H-K, Thanks for sending words! It really helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Academic Partners slider has a breaking animation during the starting few seconds
6 participants