-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed lazy load from the slider settings #5806
Conversation
🚀 Preview for commit 0c1eb61 at: https://66baf8cea9b1dbbe7df8c76c--layer5.netlify.app |
Signed-off-by: Harsh Kumar <[email protected]>
0c1eb61
to
d6d36a4
Compare
🚀 Preview for commit d6d36a4 at: https://66bb15d466193ed5f6f3f56b--layer5.netlify.app |
@H-A-R-S-H-K, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
@H-A-R-S-H-K, have we discussed this in the meeting? |
@Ashparshp Yes we discussed that this needed to be fixed. |
Thank you for your contribution @H-A-R-S-H-K LGTM! |
@@ -10,7 +10,6 @@ import "slick-carousel/slick/slick-theme.css"; | |||
|
|||
const settings = { | |||
initialSlide: 1, | |||
lazyLoad: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why lazyload is being a issue here. Lazy loading is kind of important because we don't want to hinder the experience of users if the images taking time to load. So why lazy loading is creating a issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@H-A-R-S-H-K @Ashparshp are either of you investigating this?
@H-A-R-S-H-K, any updates? |
@H-A-R-S-H-K checking in once again. |
Sorry for the delayed response. Was busy for a while and I couldn't get a work around this issue so that's why closing the PR. |
@H-A-R-S-H-K, Thanks for sending words! It really helps. |
This PR fixes #5805
Updated Behaviour:
Screen.Recording.2024-08-13.at.11.23.42.AM.mov