Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cert Manager Screenshots, under How It Works section #5793

Closed
wants to merge 0 commits into from

Conversation

Aarya01Patil
Copy link
Contributor

@Aarya01Patil Aarya01Patil commented Aug 6, 2024

Description

This PR fixes #4864

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Aug 6, 2024

🚀 Preview for commit c4e7a69 at: https://66b22b501e5763214aff7c97--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@Aarya01Patil Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@sudhanshutech
Copy link
Member

please keep the image by creating that component specific directory not directly under images. See other example @Aarya01Patil

@Aarya01Patil
Copy link
Contributor Author

Hey @sudhanshutech created the component directory and pushed the new changes , please review and let me know if any further changes are needed

@l5io
Copy link
Contributor

l5io commented Aug 17, 2024

🚀 Preview for commit 797a775 at: https://66c03f729a4e0d2a3faa67b1--layer5.netlify.app

@Aarya01Patil
Copy link
Contributor Author

Hey @vishalvivekm can you please review this PR and let me know if any changes are needed ?

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you use webp images @Aarya01Patil ?

@l5io l5io temporarily deployed to commit September 25, 2024 17:31 Inactive
@l5io l5io temporarily deployed to commit September 25, 2024 18:08 Inactive
@l5io l5io temporarily deployed to commit September 25, 2024 18:11 Inactive
@l5io l5io temporarily deployed to commit September 26, 2024 11:14 Inactive
@l5io l5io temporarily deployed to commit September 26, 2024 14:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Screenshots] Cert Manager under 'How it Works See It in Action' section
4 participants