Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Buttons in sistent #5695

Open
Muhammed-Moinuddin opened this issue Jul 19, 2024 · 8 comments · May be fixed by #5705
Open

Problems with Buttons in sistent #5695

Muhammed-Moinuddin opened this issue Jul 19, 2024 · 8 comments · May be fixed by #5705
Assignees
Labels
component/ui Issues related to UI help wanted Extra attention is needed kind/bug Something isn't working

Comments

@Muhammed-Moinuddin
Copy link
Contributor

Muhammed-Moinuddin commented Jul 19, 2024

Description

Buttons in Sistent (specifically in sistent/components/modal) are not properly used.
URL: https://layer5.io/projects/sistent

  1. The next button is not shown at the end of Components/Text Input/Code.
  2. In Components/Modal there is no Previous Button.
  3. The Next button and Previous button not working properly, as per decided in today's meeting the buttons should only work for switching Tabs. Currently they also work for switching within a single Tab (for example identity/color/overview to identity/color/guidance). The switching within single Tab should NOT happen
  4. Buttons does not have preview (they don't show that where the button would lead).

Expected Behavior

  1. In the end of Components/Text Input/Code, it should have Next button .
  2. In Components/Modal/Overview there should be Previous Button.
  3. They should switch only between Tabs, for example: from identity/color to identity/spacing to identity/typography to components/button.
  4. Buttons should have preview (like here https://docs.layer5.io/cloud/). User should know that where the Button would lead.

Screenshots

Screenshot from 2024-07-22 20-40-10

Screenshot from 2024-07-19 12-29-26
Screenshot from 2024-07-19 12-28-50
Screenshot from 2024-07-19 12-28-08

Environment:

  • Host OS:
  • Browser: Chrome

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@Muhammed-Moinuddin Muhammed-Moinuddin added kind/bug Something isn't working help wanted Extra attention is needed component/ui Issues related to UI labels Jul 19, 2024
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@mannika763
Copy link
Contributor

Hey @Muhammed-Moinuddin
I would like to work on this issue.

@mannika763 mannika763 linked a pull request Jul 20, 2024 that will close this issue
1 task
@Muhammed-Moinuddin
Copy link
Contributor Author

Hey @Muhammed-Moinuddin I would like to work on this issue.

@mannika763 Last point is not decided (as mentioned). Please always wait for the assignment before making a PR.

@mannika763
Copy link
Contributor

@Muhammed-Moinuddin
Okay, I'll remember that for the future.

@Ashparshp
Copy link
Contributor

@Muhammed-Moinuddin Thank you for opening it. Let's discuss this on the website's call. Please add this as an agenda item to the [meeting minutes](https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?usp=drivesdk

@mannika763
Copy link
Contributor

mannika763 commented Jul 24, 2024

@Muhammed-Moinuddin
I would like to confirm one thing: should the buttons look like this? Right now, the buttons are smaller. Should they be spread across the whole page with a preview, as shown in this image?
image

@Muhammed-Moinuddin
Copy link
Contributor Author

Muhammed-Moinuddin commented Jul 24, 2024

@Muhammed-Moinuddin
I would like to confirm one thing: should the buttons look like this? Right now, the buttons are smaller. Should they be spread across the whole page with a preview, as shown in this image?
image

Not necessary. Just do the basic things that makes it look fine and readable.

And you can have suggestions via slack as well. Otherwise we normally review these things via website meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issues related to UI help wanted Extra attention is needed kind/bug Something isn't working
Development

Successfully merging a pull request may close this issue.

3 participants