Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Landscape Cards images are not responsive #4387

Closed
vaibhav-xp opened this issue Jun 16, 2023 · 11 comments · Fixed by #4510
Closed

Blog Landscape Cards images are not responsive #4387

vaibhav-xp opened this issue Jun 16, 2023 · 11 comments · Fixed by #4510
Assignees
Labels
kind/bug Something isn't working

Comments

@vaibhav-xp
Copy link
Contributor

Description

In blog/category/landscape, the first two categories of images are going out of the boxes on mobile view and there should be some minimum gap between the search bar and category boxes.

Expected Behavior

It should be inside of the boxes.

Screenshots

Screenshot (59)

on mobile:

screenshot_20230616-212002 (2)

Environment:

  • Host OS: Windows
  • Browser: All

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@vaibhav-xp vaibhav-xp added the kind/bug Something isn't working label Jun 16, 2023
@leecalcote
Copy link
Member

Yikes. Good eye, @vaibhav-xt

@harshit-senpai
Copy link
Contributor

hey i would like to work on it, could you assign it to me

@manshul014
Copy link

I would like to contribute to it!!

@8rxn
Copy link
Member

8rxn commented Jun 16, 2023

Assigning in chronological order.
@harshit-senpai Go Ahead and Fix this 🚀

@harshit-senpai
Copy link
Contributor

@8rxn fixed the issue facing some problems with the commit and build once i fix that i'll make the PR
Screenshot 2023-06-17 03233400

@vaibhav-xp
Copy link
Contributor Author

vaibhav-xp commented Jun 17, 2023

@leecalcote & @8rxn

Yesterday, at midnight, I raised an issue, but I forgot to indicate that I wanted to work on it myself. The first issue I brought up was acknowledged, but sadly, I missed the chance to work on my first pull request for the Layer5 Community. This has left me feeling disappointed. 😞🙁

@8rxn
Copy link
Member

8rxn commented Jun 17, 2023

Sorry to hear that @vaibhav-xt ,

Perhaps we could get you to work on something else as your first pull request,
Here's a link to all issues under Layer5 Community extending beyond this org, look out for anything that seems interesting to you

Cheers ,

@DarrenDsouza7273
Copy link
Contributor

Hi @harshit-senpai can u please update

@harshit-senpai
Copy link
Contributor

harshit-senpai commented Jun 19, 2023

Hi @harshit-senpai can u please update

I have made the PR but there was a merge conflict because of the Lighthouse test, in today's meeting I got to know that it's happening with some PR because of lighthouse test, else the PR is right.

@Ykumar1415
Copy link
Contributor

I would Like to work on this issue can you assign this issue to me?

@harshit-senpai
Copy link
Contributor

I would Like to work on this issue can you assign this issue to me?

I have fixed it, there's an issue with the lighthouse test due to which people are not able to make the PR, once that is fixed( folks are working on it ) I will make the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging a pull request may close this issue.

7 participants