Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The golangci-lint-action is present but the run command is missing #330

Closed
VaibhavMalik4187 opened this issue Aug 21, 2023 · 4 comments
Closed
Assignees
Labels
kind/bug Something isn't working

Comments

@VaibhavMalik4187
Copy link

Current Behavior

The golangci-lint action was added in commit 5390f2d but the run command was never present. As a result, the action gets installed on the runner but never runs the linter.

image

Expected Behavior

The linter must run in order to find lint errors.


Contributor Resources

@VaibhavMalik4187 VaibhavMalik4187 added the kind/bug Something isn't working label Aug 21, 2023
@welcome
Copy link

welcome bot commented Aug 21, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@VaibhavMalik4187
Copy link
Author

@leecalcote @MUzairS15 I'd like to fix this issue.

@leecalcote
Copy link
Member

@VaibhavMalik4187 way to be! Sounds good. 👍

@VaibhavMalik4187
Copy link
Author

I guess didn't do the homework properly. The lint job runs(just looked at the actions logs). My apologies for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

No branches or pull requests

2 participants