Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken hyperlink - embedding designs #343

Closed
leecalcote opened this issue Aug 9, 2024 · 6 comments · Fixed by #349
Closed

Broken hyperlink - embedding designs #343

leecalcote opened this issue Aug 9, 2024 · 6 comments · Fixed by #349
Assignees
Labels
framework/hugo good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/css language/javascript Javascript related

Comments

@leecalcote
Copy link
Member

Current Behavior

This section has a broken hyperlink - https://docs.layer5.io/meshmap/designer/export-designs/#exporting-as-embedding

Expected Behavior

Replace with new page location.


Contributor Guide and Resources

@leecalcote leecalcote added good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/javascript Javascript related language/css framework/hugo labels Aug 9, 2024
@kaushiktak19
Copy link
Contributor

kaushiktak19 commented Aug 10, 2024

Hey @leecalcote, Can you assign me this issue ? I have understood the task and am ready to get started.

@hargunkaur286
Copy link
Member

@kaushiktak19 May I know if you have the website setup and working locally?

@kaushiktak19
Copy link
Contributor

Hi @leecalcote and @hargunkaur286 ,

I've set up the documentation site locally and have addressed the broken hyperlink issue. I’ve verified the fix and created a video demonstrating the changes and how the link now correctly points to the updated page location.

Could you please review the video to ensure the fix aligns with what’s needed? If everything looks good, I’m ready to proceed with committing the changes and creating a pull request.

layer5-meshmap-docs-fix.mp4

Also, could I be assigned this issue so I can track it more effectively?

@sudhanshutech
Copy link
Member

Go ahead @kaushiktak19 .
Please add also as a agenda item for today in website meet here: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit so lets discuss this. Please join at 5:30pm IST

@kaushiktak19
Copy link
Contributor

Sure @sudhanshutech, I will join the meet and will be raising a PR for this issue soon.

kaushiktak19 added a commit to kaushiktak19/docs that referenced this issue Aug 12, 2024
@kaushiktak19
Copy link
Contributor

Hey @sudhanshutech @leecalcote @hargunkaur286, I have raised a PR for fixing this issue, do let me know if it is ready to go or something else is needed from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/hugo good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/css language/javascript Javascript related
Development

Successfully merging a pull request may close this issue.

4 participants