Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Convert nav link to external link #26

Closed
leecalcote opened this issue Oct 30, 2023 · 13 comments · Fixed by #98
Closed

[Site] Convert nav link to external link #26

leecalcote opened this issue Oct 30, 2023 · 13 comments · Fixed by #98
Assignees
Labels
framework/hugo help wanted Extra attention is needed kind/enhancement Improvement in current feature language/css language/html

Comments

@leecalcote
Copy link
Member

Current Behavior

The Playground link opens a page on docs.layer5.io.

Desired Behavior

Change the Playground link to open https://play.meshery.io instead.

Mockups

Screenshot 2023-10-29 at 7 13 57 PM

Contributor Guide

@leecalcote leecalcote added help wanted Extra attention is needed kind/enhancement Improvement in current feature language/css language/html framework/hugo labels Oct 30, 2023
@Jat1nSood
Copy link

@leecalcote Please Assign this to me

@leecalcote
Copy link
Member Author

Thanks for volunteering, @Jat1nSood. Yes, will you confirm the specifics of your approach to a fix?

@Jat1nSood
Copy link

@leecalcote although, I am not familiar with hugo but I tried and after going through the documentation and some tutorials I tried to solve the issue. One error is there that which says URLs with protocol http* are not supported . I looked and found one option i.e. to set uglyURLs = true in config.toml . It did'nt work. Also tried to add link to shortcode directory but nothing worked. I will look more.

@hemantmm
Copy link
Contributor

hemantmm commented Nov 1, 2023

Hi, @leecalcote like the playground is not visible on the page
Screenshot 2023-11-01 205928

Should I add the Playground in the navbar?

@leecalcote
Copy link
Member Author

@hemantmm, yes, I removed it since it doesn't redirect currently.

@hemantmm
Copy link
Contributor

hemantmm commented Nov 3, 2023

@leecalcote, Should I include that Playground in the navbar with the correct link provided above?

@leecalcote
Copy link
Member Author

That's what this issue calls for, yes.

hemantmm added a commit to hemantmm/docs that referenced this issue Nov 4, 2023
hemantmm added a commit to hemantmm/docs that referenced this issue Nov 4, 2023
hemantmm added a commit to hemantmm/docs that referenced this issue Nov 4, 2023
@hemantmm hemantmm mentioned this issue Nov 4, 2023
1 task
hemantmm added a commit to hemantmm/docs that referenced this issue Nov 4, 2023
@roshil1206
Copy link

I would like to work on it

@35C4n0r
Copy link
Contributor

35C4n0r commented Nov 14, 2023

@leecalcote i've got this figured out, kindly assign the issue to me.

@leecalcote
Copy link
Member Author

@roshil1206 I'm sorry to have missed your message earlier.

@35C4n0r, just as you jump in here, ping @Modern-artist (Prem Kumar in Slack) about the menu mockup that he has for this nav bar. Speaking of nav bar, we'll want for the logo and menu to be sticky and the page content to scroll underneath.

@leecalcote
Copy link
Member Author

We might want to simply reuse the mega menu from layer5io/layer5.

@35C4n0r
Copy link
Contributor

35C4n0r commented Nov 23, 2023

I'm not able to seem Prem Kumar on the slack anymore neither any mockups for the navbar here https://www.figma.com/file/5ZwEkSJwUPitURD59YHMEN/Layer5-Designs?node-id=21084%3A6224&mode=dev

@35C4n0r
Copy link
Contributor

35C4n0r commented Nov 23, 2023

We might want to simply reuse the mega menu from layer5io/layer5.

Do we want to include all the images too ?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/hugo help wanted Extra attention is needed kind/enhancement Improvement in current feature language/css language/html
5 participants