Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Mobile menu #19

Closed
leecalcote opened this issue Oct 28, 2023 · 6 comments
Closed

[Feature] Mobile menu #19

leecalcote opened this issue Oct 28, 2023 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Improvement in current feature language/javascript Javascript related

Comments

@leecalcote
Copy link
Member

leecalcote commented Oct 28, 2023

Current Behavior

This docs doesn’t have a mobile menu for visitors trying to read documentation on their mobile devices.

Implementation

identify whether or not there is a mobile friendly menu available from the Docsy.dev theme. Enable it and reuse it if so.

If one is not available from docsy theme, search for commonly used mobile menus on other Hugo teams or projects.

Mockup

Screenshot 2023-10-28 at 2 26 57 PM

Contributor Guide

@leecalcote leecalcote added good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Improvement in current feature language/javascript Javascript related labels Oct 28, 2023
@Wise-Wizard
Copy link

Hi @leecalcote, I would like to work on this issue!

@leecalcote
Copy link
Member Author

Thanks. Have you worked with Hugo sites before, @Wise-Wizard?

It turns out that there is a menu, I just couldn't see it on my iPhone. Maybe it is the coloring of the hamburger menu I'm not sure. Having said that, we do need an enhanced menu that looks like the mockup.

@abhijeetgauravm
Copy link

@Wise-Wizard any updates here?

@preyanshu
Copy link
Contributor

hiiii @leecalcote can i work on this ?

@leecalcote
Copy link
Member Author

Thanks for asking, @preyanshu.

@iArchitSharma Will you make an assessment as whether or not this issue is still valid or has already been taken care of?

@iArchitSharma
Copy link
Contributor

We already have a mobile-friendly site, so we can close this issue:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Improvement in current feature language/javascript Javascript related
Development

No branches or pull requests

5 participants