Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The key structure should be a template argument #610

Open
thompsonbry opened this issue Dec 4, 2024 · 3 comments
Open

The key structure should be a template argument #610

thompsonbry opened this issue Dec 4, 2024 · 3 comments

Comments

@thompsonbry
Copy link

This would make it possible to reuse the library with different kinds of keys. It might mean moving further toward header mostly compilation.

@thompsonbry
Copy link
Author

Closing as it will be addressed with variable length key support.

@laurynas-biveinis
Copy link
Owner

Let's close it once it's implemented, together with the varlen keys

@thompsonbry
Copy link
Author

@laurynas-biveinis As agreed, I will leave this out of the variable length key refactor.

As a heads up when templating the key into the db types, please also template in a parameter to configure an initial capacity for the buffers used to encode/decode/buffer keys. This is for an "in the object" buffer to optimize away an allocation in the vast majority of cases. If the keys are longer than this capacity, an allocation will occur. Right now this is configured as a constexpr in art_common.hpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants