Desktop: Fixes #11261 : Ensure spell-check toggle works on macOS #11388
+8
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop: Fixes #11261 : Ensure spell-check can be toggled off on macOS
This pull request addresses an issue where spell-check could not be fully disabled on the macOS desktop app, even when explicitly turned off in the settings.
Problem
On macOS, users encountered a problem when trying to disable spell-check. Although the setting was turned off, spell-check continued to underline words, suggesting that it wasn't fully disabled.
Solution
The fix ensures that:
Technical Summary
SpellCheckerServiceDriverNative.ts
file to explicitly callsetSpellCheckerEnabled(false)
when disabling andsetSpellCheckerEnabled(true)
when enabling.setLanguages
to track the session's state after each toggle and confirm that the changes have taken effect.Testing
This PR resolves the underlying issue and provides a more consistent spell-check toggle experience on the macOS platform.
Reference: Fixes #11261
demo :
Screen.Recording.2024-11-13.at.10.33.59.PM.mov