From b39f19eb294cc73c1b72ffa308ef54f4327d3e9a Mon Sep 17 00:00:00 2001
From: Yuki Nishijima <yuki@xpillars.software>
Date: Fri, 7 Mar 2025 15:16:23 +0900
Subject: [PATCH 1/4] Provide a specific thread name for inspection
---
lib/ld-eventsource/client.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ld-eventsource/client.rb b/lib/ld-eventsource/client.rb
index e677446..9d93b31 100644
--- a/lib/ld-eventsource/client.rb
+++ b/lib/ld-eventsource/client.rb
@@ -143,7 +143,7 @@ def initialize(uri,
Thread.new do
run_stream
- end
+ end.name = "SSE/Client/host:#{uri.host}"
end
#
From 2982c30416822d4a00ee263536230a5227855a5d Mon Sep 17 00:00:00 2001
From: Matthew Keeler <mkeeler@launchdarkly.com>
Date: Fri, 7 Mar 2025 13:21:42 -0500
Subject: [PATCH 2/4] Remove host from SSEClient name
---
lib/ld-eventsource/client.rb | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/ld-eventsource/client.rb b/lib/ld-eventsource/client.rb
index 9d93b31..6355a62 100644
--- a/lib/ld-eventsource/client.rb
+++ b/lib/ld-eventsource/client.rb
@@ -141,9 +141,7 @@ def initialize(uri,
yield self if block_given?
- Thread.new do
- run_stream
- end.name = "SSE/Client/host:#{uri.host}"
+ Thread.new { run_stream }.name = 'LD/SSEClient'
end
#
From 6fe90ad6d9f0ca0ba5af09b9bd3c1085b3c648d2 Mon Sep 17 00:00:00 2001
From: Matthew Keeler <mkeeler@launchdarkly.com>
Date: Fri, 7 Mar 2025 13:21:53 -0500
Subject: [PATCH 3/4] jRuby 9.2 isn't supported on ubuntu any more
---
.github/workflows/ci.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2d92aab..0d33d58 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -14,6 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
+ fail-fast: false
matrix:
ruby-version:
- '2.5'
@@ -22,7 +23,6 @@ jobs:
- '3.0'
- '3.1'
- '3.2'
- - jruby-9.2
- jruby-9.3
- jruby-9.4
From 06d1b8c1d719ffed74ed59465cfd9351f665cd52 Mon Sep 17 00:00:00 2001
From: Matthew Keeler <mkeeler@launchdarkly.com>
Date: Fri, 7 Mar 2025 13:22:22 -0500
Subject: [PATCH 4/4] Old hold over files
---
scripts/gendocs.sh | 12 ------------
scripts/release.sh | 30 ------------------------------
2 files changed, 42 deletions(-)
delete mode 100755 scripts/gendocs.sh
delete mode 100755 scripts/release.sh
diff --git a/scripts/gendocs.sh b/scripts/gendocs.sh
deleted file mode 100755
index 45ff28c..0000000
--- a/scripts/gendocs.sh
+++ /dev/null
@@ -1,12 +0,0 @@
-#!/bin/bash
-
-# Use this script to generate documentation locally in ./doc so it can be proofed before release.
-# After release, documentation will be visible at https://www.rubydoc.info/gems/ld-eventsource
-
-gem install --conservative yard
-gem install --conservative redcarpet # provides Markdown formatting
-
-# yard doesn't seem to do recursive directories, even though Ruby's Dir.glob supposedly recurses for "**"
-PATHS="lib/*.rb lib/**/*.rb lib/**/**/*.rb"
-
-yard doc --no-private --markup markdown --markup-provider redcarpet --embed-mixins $PATHS - README.md
diff --git a/scripts/release.sh b/scripts/release.sh
deleted file mode 100755
index 81aac06..0000000
--- a/scripts/release.sh
+++ /dev/null
@@ -1,30 +0,0 @@
-#!/usr/bin/env bash
-
-# This script updates the version for the library and releases it to RubyGems
-# It will only work if you have the proper credentials set up in ~/.gem/credentials
-
-# It takes exactly one argument: the new version.
-# It should be run from the root of this git repo like this:
-# ./scripts/release.sh 4.0.9
-
-# When done you should commit and push the changes made.
-
-set -uxe
-
-VERSION=$1
-GEM_NAME=ld-eventsource
-
-echo "Starting $GEM_NAME release."
-
-# Update version in version.rb
-VERSION_RB_TEMP=./version.rb.tmp
-sed "s/VERSION =.*/VERSION = \"${VERSION}\"/g" lib/$GEM_NAME/version.rb > ${VERSION_RB_TEMP}
-mv ${VERSION_RB_TEMP} lib/$GEM_NAME/version.rb
-
-# Build Ruby gem
-gem build $GEM_NAME.gemspec
-
-# Publish Ruby gem
-gem push $GEM_NAME-${VERSION}.gem
-
-echo "Done with $GEM_NAME release"
\ No newline at end of file